Atomicorp / openvas-docker

A docker container for openvas
68 stars 28 forks source link

Rsync proxy support #4

Open atomicturtle opened 6 years ago

atomicturtle commented 6 years ago

This was my test case I used before, which didnt yeild the results you had in yours:

docker build --build-arg HTTP_PROXY=http://172.17.0.1:3128 --build-arg http_proxy=http://172.17.0.1:3128 --build-arg RSYNC_PROXY=http://172.17.0.1:3128 .

nachfuellbar commented 6 years ago

Sry, i think there was an missunterstanding. I said "start container" (your "old" container with pretty old defintions) But i'm trying to build it, to get comparative values (although i'm already at 2h before even updating defintions; shitty IO it seems)

Maybe RSYNC_PROXY=172.17.0.1:3128 would do the trick because it should be used without protocol

nachfuellbar commented 6 years ago

Download via RSYNC was less than 10 Minutes for me and now there is a sqlite command running with 100% CPU ;) I will try building docker image without update and only update it on container start

nachfuellbar commented 6 years ago

Most of the time the build was waiting for IO Even though about 3h is pretty long, it's much less than your experience

420b83feecb8 3 minutes ago /bin/sh -c #(nop) EXPOSE 443/tcp 0 B
e680d33626ac 5 minutes ago /bin/sh -c #(nop) CMD ["/bin/sh" "-c" "/run. 0 B
3167e2d58046 7 minutes ago |1 HTTP_PROXY=http://XXX:8080 /bin 3.297 GB
5e1ad0e6bc6e 2 hours ago /bin/sh -c #(nop) ADD file:c285b550fa721031ba 174 B
e54edfeaff4b 2 hours ago /bin/sh -c #(nop) ADD file:ab528c9e7f61aa399c 46.91 kB
028d6be4b124 2 hours ago /bin/sh -c #(nop) ADD file:30fb16f9de6e874b80 1.196 kB
158ccd962f76 2 hours ago /bin/sh -c #(nop) ADD file:54edd15aecee4fab0f 2.41 kB
6ffd421eb199 3 hours ago /bin/sh -c #(nop) MAINTAINER Support <suppor 0 B

atomicturtle commented 6 years ago

OK gotcha, so mostly this is just a documentation update right, it sounds like the variable passes through to the sync scripts right? If so could you take the first stab at it and send a PR?