MTAD-001 -- Line Changes -- Detect A Subway Rerouting Over Another Line

[Atomox]

When a subway is traveling over another line, detect which line it reroutes over, include starting and ending station.

This ticket is only for LINE CHANGES, not local vs Express.

E.X.

• Some southbound [2] and [3] trains are stopping along the [1] line from Chambers St to South Ferry then end.
• Some northbound [R] trains are stopping on the [Q] line from 57 St-7 Av to Lexington Av-63 St, then over the [F] line from Lexington Av-63 St to Jackson Heights-Roosevelt Av.
• Some northbound [E] trains are stopping long the [C] line from 50 St to 168 St.

Patterns:

A-overC

[E] trains are rerouted in both directions via the [F] between Jackson Hts-Roosevelt Av and West 4 St
Some northbound [E] trains are stopping long the [C] line from [Mn162-A25] to [Mn605-A09].

A-overC-thenD

Southbound [D] trains are stopping along the [C] line from [Mn614-A24] to [Mn167-A32] then along the [F] line to [Bk58-D43].
Some northbound [R] trains are stopping on the [Q] line from [Mn9-R14] to [Mn223-B08], then over the [F] line from [Mn223-B08] to [Qs616-G14]
Northbound [F] trains are stopping along the [A] line from Jay St-MetroTech to 42 St-Port Authority, then stopping along the [E] line to Jackson Heights-Roosevelt Av.

AB-overC

Some northbound [A] and [C] trains are stopping along the [F] line from [Bk636-A41] to [Mn167-A32]

A-overC-D-overE

Southbound [R] trains are stopping along the [Q] line from [Mn623-R23] to [Bk26-R30]. Some southbound [R] trains are stopping along the [F] line from [Qs272-G20] to [Mn167-A32] then via the [D] line to [Bk26-R30]

AB-overC-D-overE

[A] and [C] trains are stopping along the [D] line between [Mn167-A32] and [Mn614-125] in both directions. [E] Trains are stopping along the [F] line between [Qs616-G14] and [Mn167-A32] in both directions.

Acceptance Criteria:

• Detect route changes in a message.
• Structure like so:

  route_change: {
  message: '[E] trains are rerouted in both directions via the [F] between [Qs616-G14] and [Mn167-A32]',
  trains: ["E"],
  route: [
      {
          train: "E",
          along: "F",
          from: 'Qs616-G14',
          to: 'Mn167-A32',
      },
  ],
  }

• A test with at least 5 events checking route changes.

[Atomox]

Working for some messages. Need to handle multiple redirect messages in a single message, such as: A ov C. Also, R over F.

[Atomox]

Broke out archives and assembled an archive of just route changes.

[Atomox]

Test data updated with expected structure. Added new route diversions to archive route-change-only json data.

[Atomox]

• Added working tests to detect line change array expected vs actual.
• fixed 2 bugs
  • trim train line names before insert
  • station ID parsing of [BORO-ID-GID] now allows for 1 digit in ID, which was causing some misses.
• Single/compound route changes for a SINGLE line seems to work well. Messages with multiple, unrelated changes are not works:

E.G.

• R trains run over the Q from x to y, then over the F to z. (work)
• A C trains .... (work)
• R trains on F from A to B. W trains over Q from x to y (DOES NOT WORK)

[Atomox]

Some wonky line change patterns:

• [W] service operates between [Mn635-R27] and [Mn9-R14], and via the [Q] to/from 96 St
• [Q] service operates between Stillwell Av and 96 St , and is rerouted as follows: Via the [D] between DeKalb Av and 47-50 Sts . Via the [F] between 47-50 Sts and Lexington Av/63 St .

[Atomox]

Standard patterns for two different lines now work in tandem.

E.G.:

• R trains on F from A to B. W trains over Q from x to y (Now Works)

[Atomox]

Some tests fail because of station alias issues. Shifting focus to address the 36 St / 36 St problem in MTAD-05 first.

[Atomox]

When parsing A(B) over C (then over D). After stations in C, group .* with manditory D, but make the entire capture group optional.

[Atomox]

Everything has test, and is working, except:

• A-operates-then-overC-thenD (now MTAD-014)
• AB-overC-end (now MTAD-010)

[Atomox]

Broke out 2 remaining patterns (trains end / trains operate between, then). So, everything passing for MTAD-001. Closing.