search

Aton-Kish / reinforced-shulker-boxes

Minecraft fabric mod to add reinforced shulker boxes.
MIT License
3 stars 4 forks source link

[Bug]Creative Empties Reinforced Shulker Inventories #29

Closed uselessSABOTAGE closed 2 years ago

uselessSABOTAGE commented 2 years ago

Describe the bug

A clear and concise description of what the bug is: When in creative mode any interaction with a reinforced shulker box will cause the shulker to “return” empty when dropped.

To Reproduce

Steps to reproduce the behavior:

  1. Open an already placed shulker with items in it while in creative
  2. Then break said shulker and when you view it in your inventory it reads “Empty”
  3. Then when placed, it is indeed empty. Further, one doesn’t even have to open or view the shulker as this will happen even when moving a shulker from say a chest to an ender chest.

Expected behavior

A clear and concise description of what you expected to happen: I would expect no item loss during interactions with reinforced shulker boxes while in creative

Screenshots

If applicable, add screenshots to help explain your problem.

Environment

Logs

Pastebin the log [e.g. logs/latest.log] and link it below:

Additional context

Add any other context about the problem here.

Aton-Kish commented 2 years ago

Hmmm, I tried the steps to reproduce but no bugs occurred. Although I have developed this mod while paying attention to the creative behavior, I don't remember occurring it. Can you tell me your environment? e.g. the mod version, any other mods you have installed (if you have)

uselessSABOTAGE commented 2 years ago

Hello!

Thank you for the reply. I did some initial troubleshooting before reporting here, however it went like this:

1 - I uninstalled everything except the reinforced mods 2 - I checked creative mode - no issues worked as expected 3 - One by one I reinstalled each mod until creative mode "broke" the boxes again 4 - ShulkerBoxToolTip seemed to be the culprit, so I uninstalled it and tried Quick Shulkers - which also caused the same issue 5 - I uninstalled Quick Shulkers and tried MiniHud's and Tweakeroo's version of shulker preview - same issue ocured with both 6 - I gave up and submitted this bug report

I run a server for my family of four on Apex hosting running Fabric 1.18.1

We have the following mods installed:

We use Cardboard and its companion iCommon to run some Paper plug-ins for a home system through BareEssentials and LuckPerms. I tested with just those installed with the reinforced storage mods and it worked as expected, so I don't believe the issue lies there. I truly believe the issue rests with attempting some sort of "tooltip" pull/refresh. For example, while in creative, I placed an empty netherite shulker then grabbed two stacks of random stone and tossed those in. I broke the shulker and it dropped - indicating it had items in the shulker. I picked it up and the dropped shulker entity went to a different inventory slot than the shulker I used to placed the dropped shulker entity. However, when I hovered over the shulker I just picked up, it returned the tooltip message of "Empty" and upon placing it again, it was indeed empty.

Thank you in advanced for looking into this. I truly appreciate your time and effort!

Let me know if you need any additional information and best of luck in solving this issue.

uselessSABOTAGE commented 2 years ago

Logs-224FEB2022.zip Mods-24FEB2022.zip

P.S. I zipped my logs and mods folder and attached them for your reference so you know exactly what we have.

Aton-Kish commented 2 years ago

Thank you for telling me the details. I’ll look into it later.

Btw, it doesn’t occur with vanilla shulkers, right?

uselessSABOTAGE commented 2 years ago

Correct, vanilla shulkers do not have this issue. Thanks, again!

Aton-Kish commented 2 years ago

Though I tried single play with your mod configuration, it seemed no bugs occurred. So is there a bug in the server? Since I'm not familiar with apex hosting and with plugin servers like Bukkit, Spigot, Sponge, or Paper, the reproduction may take some time.

Then, I fixed another bug in the reinforced shulker boxes.

It may not be related to this bug, but I'll let you know.

Aton-Kish commented 2 years ago

Oops, I was able to reproduce it. And if disabled Cardboard, the bug was fixed. When I enabled Cardboard with/without the plugin, it happened again. So probably caused by Cardboard.

Aton-Kish commented 2 years ago

I don't know well what they are doing, but it seems they are tweaking the vanilla shulker box (links below).

I hypothesize the reinforced shulker boxes were empty because they haven't been tweaked.

uselessSABOTAGE commented 2 years ago

Thanks for the update. I will try your beta versions and see what I can do about Cardboard. Do you know about a good home system for Fabric?

uselessSABOTAGE commented 2 years ago

I tested it (with Cardboard still installed) and the new version did not fix the issue.

Aton-Kish commented 2 years ago

Do you know about a good home system for Fabric?

No, I don't...

I tested it (with Cardboard still installed) and the new version did not fix the issue.

Yes, if my hypothesis is correct, unfortunately, I can't fix this bug. This is an issue with Cardboard. Cardboard targets only vanilla shulker boxes, so this bug probably happens not only with my mods but also with other shulker box mods. In fact, I reproduced the same issue with endritemod's shulker box and Kyrptonaught's Upgraded Shulkers.

uselessSABOTAGE commented 2 years ago

Thank you for your help with this. I truly appreciate your effort. I've decided to abandon Cardboard at this time. I believe it is causing us other issues as well. If you would like, you may mark this issue as closed/resolved. Thanks again!