search

Aton-Kish / reinforced-shulker-boxes

Minecraft fabric mod to add reinforced shulker boxes.
MIT License
3 stars 4 forks source link

[Bug] #55

Open AAAAAAAAAAAAXE opened 1 year ago

AAAAAAAAAAAAXE commented 1 year ago

Describe the bug

Shulker boxes (Netherite Upgrade) found almost empty (In a single player world)

To Reproduce

Steps to reproduce the behavior: Put 6 full shulkers down and wait for the stuff to disappear

  1. First step ...
  2. Second step ...

Expected behavior

The shulkers were supposed to be full

I put down the shulkers because I wanted my inventory a little less chaotic and I went away for 20 minutes circa. When I came back where I put them down 5 out of 6 shulkers were almost empty

Screenshots

Screenshot (2125) Screenshot (2126) Screenshot (2127) Screenshot (2128)

Environment

Logs

Aton-Kish commented 1 year ago

I feel like there is not enough information to reproduce it. Could you provide a list of the mods you have installed and the logs when it occurred?

Meshiest commented 1 year ago

I see that the number of item stacks before the cutoff is 27 which leads me to believe it might be related to mods that interact with shulker NBT data.

In cases like drops-into-shulker, the NBT was parsed from a standard ShulkerBoxBlockEntity which always had a 27 length inventory array. This resulted in the mod thinking boxes were full if the first 27 stacks were full or wiping any items after the 27th index. (fix).

For something like quickshulker it expects "Upgraded" Shulkers to implement this UpgradableShulker interface or use an inventory size of 27 by default. This issue causes the bundling feature to wipe items after the 27th slot or unbundle starting from the 27th slot. (fix)

ItsYusei99 commented 1 year ago

Its QuickShulker's fault, can someone fix it?

Aton-Kish commented 1 year ago

It seems that the issue with QuickShulker arises only when using the bundle feature, so I have temporarily disabled bundling in version 2.5.0. Once this PR https://github.com/kyrptonaught/shulkerutils/pull/1 is merged, I plan to enable it again.