Aton-Kish / reinforced-shulker-boxes

Minecraft fabric mod to add reinforced shulker boxes.
MIT License
3 stars 4 forks source link

Fix Incomplete Interoperability With Quickshulker #59

Closed Meshiest closed 1 year ago

Meshiest commented 1 year ago

Before this change, the bundling feature of quickshulker deleted items after the 27th slot because the default behavior depends on UpgradableShulker and assumes all shulker boxes are 27 slot inventories.

This PR implements that interface and fixes that bundling issue.

Aton-Kish commented 1 year ago

Thanks!

Aton-Kish commented 1 year ago

Upon careful consideration, it seems that this mod should not rely on the interface of the shulkerutils, as it allows for gameplay even without the quick shulker mod. need to revert for now and organize the issues.

Meshiest commented 1 year ago

Ah sorry about that. I forgot about the mod actually needing to be there to provide that functionality. Thank you for taking the time to review my changes.

I see two paths for fixing this:

Aton-Kish commented 1 year ago

I would like to avoid the former as it could potentially disrupt the release cycle. I prefer the latter. Since ShulkerBoxBlockEntity has a public method size() that represents the size of the inventory, I believe don't need a mixin. like ((ShulkerBoxBlockEntity) item.getBlock().createBlockEntity()).size()

Meshiest commented 1 year ago

Should https://github.com/kyrptonaught/shulkerutils/pull/1 get merged and kryptonaught updates quickshulker, the issues will be fixed!

Thanks for the feedback about ShulkerBoxBlockEntity.size(), I've made PRs to drops-into-shulker and simple-shulker-preview to address my error.

ItsYusei99 commented 1 year ago

QuickShulker did not update, there is a fix for this issue?