[Bug] Not 100% compatible with "Enchanted Shulkers"

K0KE11 commented 1 year ago

Describe the bug

When you enchant a Netherite Reinforced Shulker with either "Refill" or "Siphon" it does work but only for 21 slots. What this means is that for example if I have a Netherite Reinforced Shulker enchanted with "Refill" filled with full stacks of Scafolding and then use the scafolding, the shulker will refill my stack in hand but will also delete all the stacks of scafolding in it's inside except 27 of them. This also happens with the "Siphon" enchantment. It works just not beyong 27 stacks AKA a normal shulkerbox.

To Reproduce

Steps to reproduce the behavior:

First step: Enchant a reinforced shulker with the "Refill" enchatment.
Second step: Fill the shulker with stacks of scafolding (108 slots).
Third step: With scafolding in your hand and the shulker in any part of your inventory start placing scafolding blocks.
Fourth step: Note that the scafolding in your hand won't run out because is being refilled by the ones in the shulker.
Fifth step: Place the shulker back on the ground to check how many scafolding you've used.
Sixth step: You will realize that of the 108 stakcs of scafolding you put on the shulker less than 27 remain, which effectively means by using the refill enchatment even though it worked, it also limited the amount of items you could use to less or equal to 21 stacks, as if it was a normal shulker.

Expected behavior

I expected the items in the shulkerbox to remain without being deleted automatically by using the enchatment. Meaning if I had a "Netherite Reinforced Shulker" with the "Refill" enchatment and filled it's 108 slots with full stacks of dirt to then only use a stack of dirt, when I opened back the shulker there should be 107 stacks not 20.

Screenshots

This is a screenshot of the mods I was using.

Although originally I was using more mods I decided to test it bare bones to see if it was an incompatibility issue but apparently it isn't

Environment

According to me this is the envirorment where I'm using the mod:

Minecraft: [1.19.0]
Fabric Loader: [0.14.22]
Fabric API: [0.58.0+1.19]

This is the name of the file of your mod: reinforced-shulker-boxes-2.2.0+1.19

This is what your mod says in the manifest:

Manifest-Version: 1.0 Fabric-Gradle-Version: 7.4 Fabric-Loom-Version: 1.0.11 Fabric-Mixin-Compile-Extensions-Version: 0.5.0 Fabric-Minecraft-Version: 1.19.2 Fabric-Tiny-Remapper-Version: 0.8.5 Fabric-Loader-Version: 0.14.9 Fabric-Mixin-Version: 0.11.4+mixin.0.8.5 Fabric-Mixin-Group: net.fabricmc Fabric-Mapping-Namespace: intermediary

Also the version of the enchanted shulkers mod is this one or well the name of the file anw: enchantedshulkers-1.0.4+1.19 I download it from curseforge.

Logs

I don't know what this is but let me know and I'll provided if need it.

Additional context

Here's a video of me demostrating the issue. https://gofile.io/d/SlMb2V

allanonmage commented 1 year ago

I didn't notice this bug report, but just reported it/requested compatibility on Enchanted Shulkers' Github and then came over here to see if anyone else had the same problem.

In my testing, which was using Siphon, not Refill, the magic number was 27, not 21 though. 27 is the normal max capacity of a shulker box. I also found that the two mods working together would destroy items after the normal capacity of a shulker box.

I see that you two mod authors have worked together before, so hopefully you guys are still working together.

Server JAR: fabric-server-mc.1.19.2-loader.0.14.19-launcher.0.11.2.jar

Client mod list:```

(Fabric)GlowInkPlus-1.19.x-1.2.0.jar AllStackable-v1.5.6-1.19.jar AncientVessels-v1.0.0-1.19.2-Fabric.jar apollo-add-struc-mod-1.19-v1.3.3.jar architectury-6.5.85-fabric.jar areas-1.19.2-4.3.jar audioplayer-1.19.2-1.6.2.jar automated-crafting-1.4.7+MC1.19-1.19.2.jar awesomedungeon-fabric-1.19.2-3.1.0.jar awesomedungeonend-fabric-1.19.2-3.1.1.jar awesomedungeonnether-fabric-1.19.2-3.1.1.jar BagOfHolding-v4.1.6-1.19.2-Fabric.jar BasicNetherOres-1.19.2-8.2.0-Fabric.jar bclib-2.1.6.jar BetterAnimationsCollection-v4.0.5-1.19.2-Fabric.jar betterbeds-1.2.0.jar BetterF3-4.0.0-Fabric-1.19.2.jar BetterTridents-v4.0.1-1.19.2-Fabric.jar biggerspongeabsorptionradius-1.19.2-3.1.jar bobby-4.0.1.jar Bookshelf-Fabric-1.19.2-16.3.20.jar bottleyourxp-1.19.2-3.1.jar breedablekillerrabbit-1.19.2-3.2.jar cloth-config-8.2.88-fabric.jar collective-1.19.2-6.53.jar comforts-fabric-6.0.4+1.19.2.jar configurableextramobdrops-1.19.2-3.0.jar configured-fabric-2.0.0-1.19.2.jar copperhopper-0.0.12+1.19.2.jar CorgiLib-fabric-1.19.2-1.0.0.32.jar cryingportals-1.19.2-2.3.jar ctov-3.1.8.jar cullleaves-fabric-3.0.1.jar cyclepaintings-1.19.2-3.2.jar DeathFinder-v4.1.2-1.19.2-Fabric.jar despawningeggshatch-1.19.2-4.1.jar DiagonalFences-v4.2.3-1.19.2-Fabric.jar DisableCustomWorldsAdvice-3.0.jar disenchanter-0.1.7+1.19.jar dismountentity-1.19.2-3.0.jar DungeonsArise-1.19.2-2.1.54-fabric.jar EasyAnvils-v4.0.6-1.19.2-Fabric.jar EasyMagic-v4.3.2-1.19.2-Fabric.jar edibles-1.19.2-4.1.jar enchantedshulkers-1.0.4+1.19.jar EnchantingInfuser-v4.2.2-1.19.2-Fabric.jar end-goblin-traders-1.5.2.jar enderitemc-enderitemod-1.4.1-1.19.2.jar enderscape-0.4.1-1.19.2.jar Enderswords-v1.0.1-1.19.2-Fabric.jar endportalrecipe-1.19.2-5.0.jar enhancedblockentities-0.7.2+1.19.2.jar expanded-enderchest-fabric-1.0.0+1.19.2.jar extractpoison-1.19.2-3.1.jar fabric-api-0.76.0+1.19.2.jar fabric-language-kotlin-1.8.6+kotlin.1.7.21.jar firespreadtweaks-1.19.2-2.3.jar followersteleporttoo-1.19.2-2.1.jar ForgeConfigAPIPort-v4.2.10-1.19.2-Fabric.jar FriendlyFire-Fabric-1.19.2-14.0.4.jar friendsandfoes-beekeeperhut-fabric-mc1.19.2-1.2.0.jar friendsandfoes-fabric-mc1.19.2-1.8.0.jar friendsandfoes-flowerymooblooms-fabric-mc1.19.2-1.0.0.jar FrogLegs-v1.1.0-1.19.2-Fabric.jar furnacerecycle-1.19.2-2.0.jar geckolib-fabric-1.19-3.1.40.jar geodefabric-1.1.8-1.19.2.jar giantspawn-1.19.2-4.5.jar glowingbanners-1.3.0.jar glowstoneinc-1.19.2-2.jar goblintraders-fabric-1.8.1-1.19.2.jar grindstonesharpertools-1.19.2-3.1.jar healingcampfire-1.19.2-5.1.jar hoetweaks-1.19.2-3.2.jar HorseExpert-v4.0.0-1.19.2-Fabric.jar impaled-1.1.4.jar Incendium_1.19.3_v5.1.6.jar indium-1.0.9+mc1.19.2.jar inventorytabs-0.8.1-1.19.x.jar inventorytotem-1.19.2-3.0.jar lambdynamiclights-2.2.0+1.19.2.jar lanterns-belong-on-walls-1.4.0-1.19.jar libraryferret-fabric-1.19.2-4.0.0.jar litematica-fabric-1.19.2-0.12.7.jar lithium-fabric-mc1.19.2-0.11.1.jar malilib-fabric-1.19.2-0.13.0.jar milkallthemobs-1.19.2-3.0.jar mineralchance-1.19.2-3.1.jar minihud-fabric-1.19.2-0.23.3.jar mob-captains-v2.1.0.jar modmenu-4.1.2 for java 1.19.2.jar More-slabs-stairs-walls-fabric-2.4.0+1.19.2.jar MoreBows-1.0.10+1.19.2.jar morechests-fabric-1.19.2-1.0.2.jar moremcmeta-1.19-3.0.5-fabric.jar morevillagers-fabric-1.19-4.0.2.jar morezombievillagers-1.19.2-3.3.jar mostructures-1.4.3+1.19.2.jar MouseTweaks-fabric-mc1.19-2.22.jar mythic-mounts-1.19.2-7.2.jar naturallychargedcreepers-1.19.2-3.2.jar netherchest-mc1.19-4.0.jar NoChatReports-FABRIC-1.19.2-v1.13.12.jar Nullscape_1.19.3_v1.2.1.jar nutritiousmilk-1.19.2-3.1.jar nyfsquiver-Fabric-0.5.1-1.19.2.jar observable-3.3.1.jar Oh_The_Biomes_You'll_Go-fabric-1.19.2-2.0.1.1.jar owo-lib-0.9.3+1.19.jar Patchouli-1.19.2-77-FABRIC.jar phosphor-fabric-mc1.19.x-0.8.1.jar placeableblazerods-1.19.2-3.0.jar polymorph-fabric-0.46.1+1.19.2.jar PortableHole-v4.0.0-1.19.2-Fabric.jar pumpkillagersquest-1.19.2-3.2.jar PureAmethystTools-v1.0.0-1.19.2-Fabric.jar PureCopperTools-v1.0.0-1.19.2-Fabric.jar PureEmeraldTools-v1.0.0-1.19.2-Fabric.jar PuzzlesLib-v4.3.12-1.19.2-Fabric.jar rainbegoneritual-1.19.2-3.0.jar randomvillagenames-1.19.2-3.2.jar reinforced-barrels-2.3.0+1.19.jar reinforced-chests-2.2.0+1.19.jar reinforced-shulker-boxes-2.2.0+1.19.jar replantingcrops-1.19.2-5.1.jar repurposed_structures_fabric-6.3.18+1.19.2.jar respawningshulkers-1.19.2-3.5.jar sheepconsistency-1.0.4.jar shulkerboxtooltip-fabric-3.2.2+1.19.2.jar shulkerdropstwo-1.19.2-3.1.jar skeletonhorsespawn-1.19.2-3.6.jar smelting-plus-v1.0.2.jar sodium-fabric-mc1.19.2-0.4.4+build.18.jar stackrefill-1.19.2-4.0.jar strayspawn-1.19.2-3.3.jar Structory_1.19.3_v1.3.1a.jar Structory_Towers_1.19.3_v1.0.2.jar TerraBlender-fabric-1.19.2-2.0.1.130.jar The_Graveyard2.2(FABRIC)_for_1.19.2.jar thonkutil-2.15.4+1.19.jar TinySkeletons-v4.2.2-1.19.2-Fabric.jar totw_additions-1.2.3-1.19.x-fabric.jar Towns-and-Towers-v.1.10.1-FABRIC-1.19.2.jar transcendingtrident-1.19.2-4.2.jar trinkets-3.4.2.jar tweakeroo-fabric-1.19.2-0.14.3.jar UniversalBoneMeal-v4.2.0-1.19.2-Fabric.jar UniversalEnchants-v4.2.9-1.19.2-Fabric.jar vanilla-refresh-1.4.11c.jar villagernames-1.19.2-5.2.jar voicechat-fabric-1.19.2-2.3.24.jar wardenloot-1.0.9-1.19.x.jar wooltweaks-1.19.2-3.1.jar wraith-waystones-3.0.7+mc1.19.2.jar xtraarrows-2.4.3-fabric-mc1.19.2.jar YungsApi-1.19.2-Fabric-3.8.9.jar YungsBetterDesertTemples-1.19.2-Fabric-2.2.2.jar YungsBetterDungeons-1.19.2-Fabric-3.2.1.jar YungsBetterMineshafts-1.19.2-Fabric-3.2.0.jar YungsBetterNetherFortresses-1.19.2-Fabric-1.0.5.jar YungsBetterOceanMonuments-1.19.2-Fabric-2.1.0.jar YungsBetterStrongholds-1.19.2-Fabric-3.2.0.jar YungsBetterWitchHuts-1.19.2-Fabric-2.1.0.jar YungsBridges-1.19.2-Fabric-3.1.0.jar YungsExtras-1.19.2-Fabric-3.1.0.jar zombiehorsespawn-1.19.2-4.6.jar zombievillagersfromspawner-1.19.2-3.4.jar [Universal]Immersive Structures-2.0.7.jar

Aton-Kish commented 1 year ago

It seems like the EnchantedShulkers mod is always setting the inventory size of Shulker Boxes to 27. If this is the case, I can't fix this issue with my mod.

https://github.com/RubixDev/EnchantedShulkers/blob/6fa8e84ff599d60e56c779195b7ae8927915ffb0/src/main/java/de/rubixdev/enchantedshulkers/Utils.java#L61

allanonmage commented 1 year ago

The other day I went looking for code to that effect, but didn't find it.

I'll take a look at that java file and see if I can lend a helping hand, might even try to commit something to Github for the first time.

⁣Dan Whaley, MCP, RVC-E, DMC-E-4K, DMC-S, CTS OIF II Veteran, USMC Threema is preferred and secure: VKTCXSPJ @.*** LinkedIn | Github | Thingiverse | Stack Overflow

On Sep 7, 2023, 10:24 AM, at 10:24 AM, Aton-Kish @.***> wrote:

It seems like the EnchantedShulkers mod is always setting the inventory size of Shulker Boxes to 27. If this is the case, I can't fix this issue with my mod.

https://github.com/RubixDev/EnchantedShulkers/blob/6fa8e84ff599d60e56c779195b7ae8927915ffb0/src/main/java/de/rubixdev/enchantedshulkers/Utils.java#L61

-- Reply to this email directly or view it on GitHub: https://github.com/Aton-Kish/reinforced-shulker-boxes/issues/64#issuecomment-1710247642 You are receiving this because you commented.

Message ID: @.***>

allanonmage commented 11 months ago

Do you have a get method to get your shulkerbox size?

Nitjsefnie commented 9 months ago

Related issue in Enchanted Shulkers repo: https://github.com/RubixDev/EnchantedShulkers/issues/24 Related PR that will close the issue on the side of Enchanted Shulkers (no action needed from Reinforced Shulkers): https://github.com/RubixDev/EnchantedShulkers/pull/29

Nitjsefnie commented 9 months ago

Also this is a duplicate of https://github.com/Aton-Kish/reinforced-shulker-boxes/issues/51(at least in name, topic is not related at all)

RubixDev commented 9 months ago

This issue is fixed on my side now

Aton-Kish / reinforced-shulker-boxes