search

Aton-Kish / your-reputation

a WTHIT/Jade plugin that displays your reputation on a tooltip with each villager.
MIT License
3 stars 8 forks source link

Forge? #21

Closed Ti0Bi closed 1 year ago

Ti0Bi commented 1 year ago

Any plans to port this mod to Forge 1.19+ (Jade)? If so, that would be great 😃

Aton-Kish commented 1 year ago

Unfortunately not. I'm not familiar with Forge mod development.

unilock commented 1 year ago

For what it's worth, I managed to get the 1.19.2 Jade version of Your Reputation running on Forge using Architectury Loom.

IIRC, I used Architectury's "1.19.2-forge-fabric-mixin" template, copied the entire source set to the common module, copied atonkish.reputation.ReputationPlugin and atonkish.reputation.provider.* to the fabric and forge modules verbatim (and deleted them from the common module), and adjusted package names and dependencies and such to get it working.

I didn't make a PR, because I think it can be optimized by keeping all Jade-related logic in the common module and delegating Jade API calls to their respective Fabric / Forge versions, rather than copying the plugin and providers in their entirety. (Jade doesn't have an intermediary library at the moment, unfortunately.)

I won't be at my computer for the next few hours, but I can upload my fork to GitHub then, if you're interested.

unilock commented 1 year ago

OK, I finally got around to uploading the fork: https://github.com/unilock/your-reputation

What needs to be done:

ColonelGerdauf commented 1 year ago

A few more TODO's that I see: