AtoraSuunva / booru

Searches boorus for images using some js magic
https://www.npmjs.com/package/booru
MIT License
78 stars 19 forks source link

Fixed a couple of things, details in commits #19

Closed CaramelFur closed 6 years ago

CaramelFur commented 6 years ago

And here we go, ma 3rd pull request. Somehow these bois cant automatically merge and I don't know why. I just added and change a couple things, mainly to fix derpibooru. It works now. (at least for me)

AtoraSuunva commented 6 years ago

There was a bug in post.js were this.rating would be undefined, [...]

That was because I forgot to add a [0] after <Regex>.exec(string) so it was trying to use an array and would just crash
Should be fixed in 78990e82a0d7cfdcbbe219acf9f4b2dabd8b1238 (aka v1.2.1) which changes a line you also changed

When I get time I'll look over how the boorus deal with credentials and see if we can just use apiKey instead so it's clearer