Wrong reference to lorawan configuration

Atos-Research-and-Innovation / IoTagent-LoRaWAN

FIWARE IoT Agent for LoRaWAN protocol (with CayenneLpp and CBOR data models)

https://fiware-lorawan.readthedocs.io/en/latest/

Other

34 stars 40 forks source link

Wrong reference to lorawan configuration #24

Closed reitsma closed 5 years ago

reitsma commented 5 years ago

In dataTranslationService.toNgsi() line 43 the lorawan configuration property is looked up. The line should be:

lorawanConf = device.internalAttributes[i].lorawan;

In other places the internalAttributes are needed, but not here. This causes a problem when using a group configuration, because then the internalAttributes are returned as an array (from Mongo I suppose).

dcalvoalonso commented 5 years ago

Thanks for having detect this issues. It should be fixed with https://github.com/Atos-Research-and-Innovation/IoTagent-LoRaWAN/pull/29

I have added some tests also to validate this.

Do you think that we can close this now?

reitsma commented 5 years ago

Sure. Let me try that too...

dcalvoalonso commented 5 years ago

:tada: This issue has been resolved in version 1.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: