Atos-Research-and-Innovation / IoTagent-LoRaWAN

FIWARE IoT Agent for LoRaWAN protocol (with CayenneLpp and CBOR data models)
https://fiware-lorawan.readthedocs.io/en/latest/
Other
34 stars 40 forks source link

[MUST] Dockerization must protect Username/Password ENV #37

Closed jason-fox closed 5 years ago

jason-fox commented 5 years ago

With the addition of Oauth2 support authentication with using FIWARE Keyrock, usernames and passwords are now part of the Docker environment variables. Currently these can only be passed using plain text. The addition of Docker Secrets support protecting these passwords is necessary to plug a potential security flaw.

This is a simple addition of a script in the same manner as PostGres (and relevant documentation of course) Cygnus does it already. This flaw relates to all IoT Agents.

https://github.com/telefonicaid/iotagent-node-lib/pull/726#discussion_r242214046

Within the Docker container, Passwords etc can only be passed protected by Docker Secrets

jason-fox commented 5 years ago

Fixed via 574335258