search

Atos-Research-and-Innovation / IoTagent-LoRaWAN

FIWARE IoT Agent for LoRaWAN protocol (with CayenneLpp and CBOR data models)
https://fiware-lorawan.readthedocs.io/en/latest/
Other
34 stars 40 forks source link

Fix #58 - Add Docker Secrets #60

Closed jason-fox closed 5 years ago

jason-fox commented 5 years ago

Port over Docker Secrets support see: https://github.com/telefonicaid/iotagent-json/pull/390

dcalvoalonso commented 5 years ago

@jason-fox Is this ready to be reviewed and merges? I see that the corresponding / twin PR in the JSON IoT Agent has been merged: https://github.com/telefonicaid/iotagent-json/pull/390 :)

jason-fox commented 5 years ago

@dcalvoalonso - yes it should be, but don't just accept my word for it, please review & test - the Dockerfile and entrypoint.sh are slightly different for each IoT Agent. I assume I haven't broken anything, but a second pair of eyes is very welcome.

dcalvoalonso commented 5 years ago

Sure, I will review it before merging and ask any doubt or comment! :)

dcalvoalonso commented 5 years ago

@jason-fox I have reviewed the changes and run some integration tests with the resulting Docker images and everything seems to be OK. :)

Thanks for the contribution!

LGTM

dcalvoalonso commented 5 years ago

:tada: This PR is included in version 1.2.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: