Atri-Labs / atrilabs-engine

🧘‍♂️ Open-source no-code & code web app builder
https://atrilabs.com
GNU General Public License v3.0
4.12k stars 182 forks source link

Add a Rating component #179

Closed cruxcode closed 1 year ago

cruxcode commented 2 years ago

The signature for the Rating component is as follows:

export type RateProps = {
  styles: React.CSSProperties;
  custom: {
    // total number of stars
    total: number;
    // rating provided i.e. number of stars that appear colored
    rating: number;
    // color of the unrated star (default #C4C4C4)
    unratedColor: string;
    // color of rated star (default yellow)
    ratedColor: string;
  };
};

const Rate: React.FC<RateProps> = React.forwardRef((ref, props) => {
  return <div></div>;
})

The user interaction should be the same as in the ant design library as here https://ant.design/components/rate/

cruxcode commented 2 years ago

The steps to add a new component can be found in this discussion #169

aryans1319 commented 2 years ago

Hey I want to work on this can you assign it to me ?

Nikhil-Singh-Parmar commented 2 years ago

The steps to add a new component can be found in this discussion #167

Sir Can you please assign this to me ?

Ayush-k-Shukla commented 2 years ago

@cruxcode In PR 167 no such steps are mentioned. and also can you assign this to me.

cruxcode commented 2 years ago

@cruxcode In PR 167 no such steps are mentioned. and also can you assign this to me.

Please look into discussion #169

eransh1 commented 2 years ago

@cruxcode do we have to make all the Rating types or any one will work?

eransh1 commented 2 years ago

@cruxcode also can you please assign this project to me?

cruxcode commented 2 years ago

@cruxcode do we have to make all the Rating types or any one will work?

Only the star one.

cruxcode commented 2 years ago

@cruxcode also can you please assign this project to me?

@eransh1 Can you try to resolve #185 ?

cruxcode commented 2 years ago

Relevant discussions for this issue https://github.com/Atri-Labs/atrilabs-engine/discussions/169 https://github.com/Atri-Labs/atrilabs-engine/discussions/184 https://github.com/Atri-Labs/atrilabs-engine/discussions/180 https://github.com/Atri-Labs/atrilabs-engine/discussions/186 https://github.com/Atri-Labs/atrilabs-engine/discussions/187

eransh1 commented 2 years ago

@cruxcode also can you please assign this project to me?

@eransh1 Can you try to resolve #185 ?

https://user-images.githubusercontent.com/110032464/190383083-fa5ee728-1327-4538-80e7-c3ed5ea8bba4.mp4

actually i was pretty much completed with this just doing final touch up , so can i do this one too?

cruxcode commented 2 years ago

@eransh1 okay go ahead with this. One question though, we want you to write the component from scratch without using the ant-design library or any other library.

eransh1 commented 2 years ago

@eransh1 okay go ahead with this. One question though, we want you to write the component from scratch without using the ant-design library or any other library.

i have used prop-types and react-icon lib in this will that be acceptable?

cruxcode commented 2 years ago

@eransh1 yes those are acceptable. Go ahead and raise a PR.

eransh1 commented 2 years ago

@eransh1 yes those are acceptable. Go ahead and raise a PR.

@cruxcode i have made my component using only javascript and css but it seems you required typescript, but i dont have any knowledge or experience in typescript so will that be acceptable too? sorry for lot of questions , i am a fresher in this.

cruxcode commented 2 years ago

@eransh1 , our entire codebase is in Typescript. We would like to see if you can translate it in Typescript.

eransh1 commented 2 years ago

@eransh1 , our entire codebase is in Typescript. We would like to see if you can translate it in Typescript.

okay thanks, will try .

niteshmodi commented 2 years ago

Hey can you assign it to me?

vamsirevada commented 2 years ago

Can you assign it to me i do want to work on it?

darshitac11 commented 2 years ago

@all-contributors please add @vamsirevada , @Ayush-k-Shukla for userTesting

allcontributors[bot] commented 2 years ago

@darshitac11

I've put up a pull request to add @vamsirevada! :tada:

darshitac11 commented 2 years ago

@all-contributors please add @Ayush-k-Shukla for userTesting

allcontributors[bot] commented 2 years ago

@darshitac11

I've put up a pull request to add @Ayush-k-Shukla! :tada:

darshitac11 commented 2 years ago

@all-contributors please add @Nikhil-Singh-Parmar for userTesting

allcontributors[bot] commented 2 years ago

@darshitac11

I've put up a pull request to add @Nikhil-Singh-Parmar! :tada:

darshitac11 commented 2 years ago

@all-contributors please add @aryans1319 for userTesting

allcontributors[bot] commented 2 years ago

@darshitac11

I've put up a pull request to add @aryans1319! :tada:

darshitac11 commented 2 years ago

@all-contributors please add @eransh1 for userTesting

allcontributors[bot] commented 2 years ago

@darshitac11

I've put up a pull request to add @eransh1! :tada:

darshitac11 commented 2 years ago

@all-contributors please add @niteshmodi for userTesting

allcontributors[bot] commented 2 years ago

@darshitac11

I've put up a pull request to add @niteshmodi! :tada: