Closed cruxcode closed 1 year ago
The steps to add a new component can be found in this discussion #169
Hey I want to work on this can you assign it to me ?
The steps to add a new component can be found in this discussion #167
Sir Can you please assign this to me ?
@cruxcode In PR 167 no such steps are mentioned. and also can you assign this to me.
@cruxcode In PR 167 no such steps are mentioned. and also can you assign this to me.
Please look into discussion #169
@cruxcode do we have to make all the Rating types or any one will work?
@cruxcode also can you please assign this project to me?
@cruxcode do we have to make all the Rating types or any one will work?
Only the star one.
@cruxcode also can you please assign this project to me?
@eransh1 Can you try to resolve #185 ?
Relevant discussions for this issue https://github.com/Atri-Labs/atrilabs-engine/discussions/169 https://github.com/Atri-Labs/atrilabs-engine/discussions/184 https://github.com/Atri-Labs/atrilabs-engine/discussions/180 https://github.com/Atri-Labs/atrilabs-engine/discussions/186 https://github.com/Atri-Labs/atrilabs-engine/discussions/187
@cruxcode also can you please assign this project to me?
@eransh1 Can you try to resolve #185 ?
actually i was pretty much completed with this just doing final touch up , so can i do this one too?
@eransh1 okay go ahead with this. One question though, we want you to write the component from scratch without using the ant-design
library or any other library.
@eransh1 okay go ahead with this. One question though, we want you to write the component from scratch without using the
ant-design
library or any other library.
i have used prop-types and react-icon lib in this will that be acceptable?
@eransh1 yes those are acceptable. Go ahead and raise a PR.
@eransh1 yes those are acceptable. Go ahead and raise a PR.
@cruxcode i have made my component using only javascript and css but it seems you required typescript, but i dont have any knowledge or experience in typescript so will that be acceptable too? sorry for lot of questions , i am a fresher in this.
@eransh1 , our entire codebase is in Typescript. We would like to see if you can translate it in Typescript.
@eransh1 , our entire codebase is in Typescript. We would like to see if you can translate it in Typescript.
okay thanks, will try .
Hey can you assign it to me?
Can you assign it to me i do want to work on it?
@all-contributors please add @vamsirevada , @Ayush-k-Shukla for userTesting
@darshitac11
I've put up a pull request to add @vamsirevada! :tada:
@all-contributors please add @Ayush-k-Shukla for userTesting
@darshitac11
I've put up a pull request to add @Ayush-k-Shukla! :tada:
@all-contributors please add @Nikhil-Singh-Parmar for userTesting
@darshitac11
I've put up a pull request to add @Nikhil-Singh-Parmar! :tada:
@all-contributors please add @aryans1319 for userTesting
@darshitac11
I've put up a pull request to add @aryans1319! :tada:
@all-contributors please add @eransh1 for userTesting
@darshitac11
I've put up a pull request to add @eransh1! :tada:
@all-contributors please add @niteshmodi for userTesting
@darshitac11
I've put up a pull request to add @niteshmodi! :tada:
The signature for the Rating component is as follows:
The user interaction should be the same as in the ant design library as here https://ant.design/components/rate/