Atri-Labs / atrilabs-engine

🧘‍♂️ Open-source no-code & code web app builder
https://atrilabs.com
GNU General Public License v3.0
4.13k stars 182 forks source link

Add a Comments Component #263

Open adityaxpique opened 1 year ago

adityaxpique commented 1 year ago

The signature of time picker component should be as follows:-

type CommentsProps = {
       styles: React.CSSProperties;
       custom: { 
        comments: {
               //Name of the guy commenting.
               name: string;
               //The time at which reply was done
               dateTime: string;
                       //The comment text 
                       text: string;
               replies: {
                 // Name of the guy replying.
                 name: string;
                 // URL to redirect where the item will redirect.
                 reply: string;
                }[];
           }[]
       };
};

export const CommentsProps: React.FC<CommentsProps> = React.forwardRef(
  (ref, props) => {
    return <div></div>;
  }
);

The design reference- 6

corners2wall commented 1 year ago

Check this before contribute

darshitac11 commented 1 year ago

Bumping up this prior discussion around why we try to avoid using libraries while adding a new component to the framework: https://github.com/Atri-Labs/atrilabs-engine/discussions/216

corners2wall commented 1 year ago

It's not just about using the library. The link can be used as a help for contribute.

darshitac11 commented 1 year ago

Yes, of course and thanks for sharing the link.

I just wanted to clarify since our first instinct is usually to use a library - a few PRs last week had to be redone because of this reason.

darshitac11 commented 1 year ago

@all-contributors please add @corners2wall for research

allcontributors[bot] commented 1 year ago

@darshitac11

I've put up a pull request to add @corners2wall! :tada:

Jitulteron7 commented 1 year ago

@darshitac11 mam plz assign me for this issue

PrinsonF77 commented 1 year ago

@darshitac11 Can you please assign this issue to me. It would also be great if I can get some direction on how or where to get started with this as it's my first time contributing to open source. Thank you!