AtriusX / Waystones

A small plugin that brings long-distance teleportation to Minecraft survival mode!
https://www.spigotmc.org/resources/waystones.93917/
11 stars 7 forks source link

Localization throws exception when config localization is set to an invalid setting #31

Open AtriusX opened 3 years ago

AtriusX commented 3 years ago

This seems to be intended behavior based off the current implementation of Localizations, however I am debating on whether or not this should be changed to be a bit more clear to users. Exceptions aren't very helpful to people who don't know how to read them, so maybe it might be a better idea to default to english and return an error message in the console instead of completely breaking.

It also appears that an exception is thrown if english is not present in the jar file for whatever reason (this happened to @NathanAdhitya while testing #27 apparently). I don't feel like this specific part of behavior should change, since it reflects a problem with the jar file itself, but I'm open to alternative ideas if offered.