search

AtriusX / Waystones

A small plugin that brings long-distance teleportation to Minecraft survival mode!
https://www.spigotmc.org/resources/waystones.93917/
11 stars 7 forks source link

Add support for custom advancements #36

Closed AtriusX closed 3 years ago

AtriusX commented 3 years ago

This PR adds a series of custom advancements to the plugin, as well as a few bug fixes. Currently the plugin includes 10 advancements, with one being unused (likely will be used in later updates). An update to the reload command has also been introduced for reloading advancements due to data loss issues related to how spigot and paper handle registering advancements.

As it stands, localization still needs to be done for the advancement messages. @NewbieOrange If you have time your help would be greatly appreciated.

AtriusX commented 3 years ago

@NewbieOrange Just double checking, are you available?

NewbieOrange commented 3 years ago

@NewbieOrange Just double checking, are you available?

Sure, will add localizations after this is finalized.

AtriusX commented 3 years ago

Great, thanks! The PR should be pretty much good to go I think. I started moving on to fix/world-ratio after this so I believe this one is pretty much ready. Will also likely need a few translations for that branch as well once its ready, just as a heads up.

AtriusX commented 3 years ago

@NewbieOrange Sorry for the delay, both this and #37 are more or less ready so you can translate them now.