search

AtriusX / Waystones

A small plugin that brings long-distance teleportation to Minecraft survival mode!
https://www.spigotmc.org/resources/waystones.93917/
11 stars 7 forks source link

Possible future PR for version 1.18 and Copper as Boost Block #44

Closed BlipRanger closed 2 years ago

BlipRanger commented 2 years ago

Just getting my feet wet, let me know what you think. I'll be testing the mod against 1.18 to see how it performs.

AtriusX commented 2 years ago

@BlipRanger Any update on this?

BlipRanger commented 2 years ago

@BlipRanger Any update on this?

I've been doing some light play-testing over the last few days and haven't had any major issues. All normal functions of the Waystones seem to operate in the same way so far.

AtriusX commented 2 years ago

I was mostly asking in relation to the code review I left above, about whether copper blocks should give less power than iron blocks. You can check it here: https://github.com/AtriusX/Waystones/pull/44#discussion_r757863847

AtriusX commented 2 years ago

@BlipRanger Pinging again to make sure you saw the previous comment

BlipRanger commented 2 years ago

Sorry, did you see the chart? I think copper is slightly more rare than iron, but it could be incorrect. I don't have 1.18 numbers yet on that.

AtriusX commented 2 years ago

Accidentally merged the PR when trying to leave a comment. It's a small enough change so I guess it's fine leaving as is. Thanks for your contribution! I'm interested in seeing what ideas you might have for #43 later.