search

Atry / protoc-gen-as3

Automatically exported from code.google.com/p/protoc-gen-as3
BSD 2-Clause "Simplified" License
55 stars 18 forks source link

compatibility with protoc 2.6.1 #50

Closed pm-nsimic closed 7 years ago

pm-nsimic commented 8 years ago

the changes allow the plugin to compile and run with protobufs 2.6.1

Atry commented 8 years ago

What is your purpose?

I think the published binary of this plugin built with Protobuf 2.4.1 works with Protobuf 2.6.x

pm-nsimic commented 8 years ago

binary maybe, but compiling from source does not work without these changes

Atry commented 8 years ago

Recently I added configuration for Travis CI. Could you update your PR to pass the CI build?

pm-nsimic commented 8 years ago

The problems are caused by the tests of the 2.6.1 protobufs needing too much memory or cpu: https://docs.travis-ci.com/user/common-build-problems/#My-build-script-is-killed-without-any-error

I am thinking of pulling the precompiled protoc and jar of version 2.6.1 instead of compiling the entire project. What do you think of that? Any other ideas how i might solve this one?

pm-nsimic commented 8 years ago

I disabled the maven tests in the Makefile. It now builds without problems on TravisCI instance