search

AtsushiSakai / rosbag_to_csv

Converter from ros bag to csv
325 stars 142 forks source link

It doesn't work on ROS Noetic. #11

Closed argahsuknesib closed 2 years ago

argahsuknesib commented 3 years ago

I am working with ROS Noetic and since it is written in python2 and the fact that PyQt4 is not available for python3. I am facing difficulty working with it. I will try porting it to python3 and I have submitted a pull request to make a new branch for the noetic and beyond.

Tiryoh commented 2 years ago

Hi @argahsuknesib, I looked at your repositories, and it looks like you've taken care of it by creating a CUI tool.
https://github.com/argahsuknesib/ROSBag-to-CSV-Python3 I've succeeded in making this PyQt-based conversion tool Python3 compatible, so I'll make a PR.

argahsuknesib commented 2 years ago

Hey @Tiryoh , thanks! that would be great.

Tiryoh commented 2 years ago

Hi @AtsushiSakai, I have created a Python 3 compatible version of this tool, but unfortunately it is not compatible with Python 2. I think there are three options:

  1. Separate branches for Python2 and Python3
    • for example, master branch for Python3 and melodic-devel branch for Python2, or Python2 for master branch and noetic-devel branch for Python3
  2. Update the master branch only. In this case, Python2 version will become not available.
  3. No support for noetic. In this case, I'm planning to fork this repository and maintain the Python3 compatible version.

What is the best way to handle this?

AtsushiSakai commented 2 years ago

Option 1 is good. I think python3 is already mainstream. So, I added the branch python2. Feel free to create a PR to support python3.

Tiryoh commented 2 years ago

Option 1 is good. I think python3 is already mainstream. So, I added the branch python2. Feel free to create a PR to support python3.

OK, thanks! I made PR #14. Please check it out.