search

AttacqueSuperior / Engine

A customized fork for the modification Attacque Supérior of the open-source implementation of the Command & Conquer: Red Alert engine using .NET/Mono and OpenGL. Runs on Windows, Linux and Mac OS X.
http://attsup.swr-productions.com
GNU General Public License v3.0
16 stars 3 forks source link

Add ProductionCost/TimeMultiplier #78

Closed MustaphaTR closed 5 years ago

MustaphaTR commented 5 years ago

Applies https://github.com/OpenRA/OpenRA/pull/15305 to here.

I have edited this to be a multiplier to be less hacky tho haven't tested much yet, so it better be tested first. I don't have much time left for today.

GraionDilach commented 5 years ago

I haven't noticed this before I go to sleep but I'll try to check this out ASAP.

MustaphaTR commented 5 years ago

Don't merge this yet. As i said on the PR on OpenRA repo, i messed something up while trying to do this with interfaces, i'll change this so it'll use interfaces.

GraionDilach commented 5 years ago

You should use conditions instead of prerequsites IMO.

MustaphaTR commented 5 years ago

Production is done thru actor infos. Conditions won't work there.

GraionDilach commented 5 years ago

Sucks. A lot, actually. This doesn't support stacking the same building for additional bonus without a bunch of complex yaml workarounds.

Then again, at this stage, the best solution I see would be to convert prereqs to booleanexpressions. but ofcourse that would be a horrible and nonsensical method of thinking... here.

Alright. I'll test this tonight. If it works as it should, I'll take it.

GraionDilach commented 5 years ago

The code itself looks okay, so it'll be merged after the fixup.

MustaphaTR commented 5 years ago

Updated also removed the GCoP from the credits since it is no longer a part of the AS.

GraionDilach commented 5 years ago

GJ. :+1: