search

AtteqCom / zsl

zsl application framework for web based services
MIT License
1 stars 1 forks source link

Feature/filter by multiple values #124

Closed Aspect26 closed 3 years ago

Aspect26 commented 3 years ago

  1. If there is some better way to test the correctness where clauses in the sqlalchemy queries than looking at the query string I'll be happy to reimplement them

  2. why does JsonServerResource._create_filter_by() uses request.args to look at the arguments and not at args param from _transform_list_args like all the other functions?

codecov-io commented 3 years ago

Codecov Report

Merging #124 (f71905e) into master (7786490) will increase coverage by 0.50%. The diff coverage is 97.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
+ Coverage   66.16%   66.67%   +0.50%     
==========================================
  Files         154      156       +2     
  Lines        5660     5746      +86     
  Branches      520      530      +10     
==========================================
+ Hits         3745     3831      +86     
  Misses       1810     1810              
  Partials      105      105
Impacted Files Coverage Δ
src/zsl/resource/resource_helper.py 83.45% <90.00%> (+2.75%) :arrow_up:
src/zsl/utils/request_helper.py 100.00% <100.00%> (ø)
tests/resource/resource_helper_test.py 100.00% <100.00%> (ø)
tests/utils/request_helper_test.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7786490...f71905e. Read the comment docs.