Attnam / ivan

Iter Vehemens ad Necem - a continuation of the graphical roguelike by members of http://attnam.com
GNU General Public License v2.0
303 stars 42 forks source link

Redundant message for staircases from auto map note #505

Closed jakwings closed 4 years ago

jakwings commented 5 years ago
staircase-map-notes
jakwings commented 5 years ago

Maybe there are other cases like this. Should show only manual notes.

The # sign and double quotes are unnecessary.

Empty notes should be deleted.

AquariusPower commented 5 years ago

the auto-note navigation helper (using 'g' '.' go on command) could instead start with '##' hinting to be ignored on the messages log indeed.

jakwings commented 5 years ago

I took some time to figure out "#t" means thrown items and the way to untag them is to "drop" them. Then I thought "#a" is a short cut for selecting that position, but it isn't.

The double "#" is no problem but the "#" shown in the messages and labels is still a bit confusing. The symbol can be shown only when editing the note.

After all, these add some mental load to me. So I think there should be an option to disable auto notes.

AquariusPower commented 5 years ago

I think there should be an option to disable auto notes.

The auto-notes are there to avoid having to navigate thru the minimap til you reach the stairs or anvil in the other side of the map, as it still doesnt recognise the mouse position to aim during "go on" mode. But a simple option to disable'em is ok too.

I took some time to figure out "#t" means thrown items and the way to untag them is to "drop" them

this could be documented in game on the thrown option, may be using F1 one day there too. I think you can also untag manually using inscribe but will surely be more annoying than dropping.

The symbol can be shown only when editing the note

should indeed, sounds good!

AquariusPower commented 5 years ago

Then I thought "#a" is a short cut for selecting that position

you mean that the floor could be engraved with '#a' to aim all throws there? check this: https://github.com/Attnam/ivan/issues/483 I will post more stuff I just thought there :)

jakwings commented 5 years ago

Ah, more clearly: The labels on the map are a nice builtin (should still be toggle-able). It is just that I don't find the auto notes particularly useful outside the map. :)

There are also other problems with "#t" like how to exclude broken bottles, banana peels and etc. Worth another issue. I'm afraid the config for auto-pickup might become as complicated as NetHack's.

jakwings commented 5 years ago

you mean that the floor could be engraved with '#a' to aim all throws there?

I mean you can press "a" and set the destination of the route.

AquariusPower commented 5 years ago

The labels on the map are a nice builtin (should still be toggle-able

they can all be toggled at once, but initially they are shown

I don't find the auto notes particularly useful outside the map. :)

outside the map they are useless and could be completely ignored while walking over on the messages log for sure! just when directly floor engraving they must be shown to edit.

other problems with "#t" like how to exclude broken bottles, banana peels and etc

actually a broken bottle and a banana peel may be dangerous (despite minor danger, least against kobolds heh), but may be, a user config option as a regex string could provide a nice ignore result and would push users even further towards learning how to "code", pcre is already there :)

btw, broken weapons are still harmful when thrown.

PS.: I just thought that, after pickup, it should simply remove the '#t' now useless tag.

I mean you can press "a" and set the destination of the route.

the "go on" route mode thru '.' is set/initiated by clicking on the map note :), not sure if I documented it..

red-kangaroo commented 4 years ago

The redundant messages from map notes were fixed.

jakwings commented 4 years ago

Confirmed!