Attnam / ivan

Iter Vehemens ad Necem - a continuation of the graphical roguelike by members of http://attnam.com
GNU General Public License v2.0
301 stars 43 forks source link

Distribute IVAN.dmg for MacOS and Fix icon for IVAN.app #525

Closed jakwings closed 5 years ago

jakwings commented 5 years ago

Wait a minute...

jakwings commented 5 years ago

Done. Download link (will expire someday) https://github.com/jakwings/ivan/releases/download/vTest/IVAN-vTest-osx.dmg

andrewtweber commented 5 years ago

Oooh nice. I'm glad we can set the icon on it. I'm seeing a white background though, is there any way to get a transparent background? Worst case scenario then red would be preferred over white.

Also pretty fuzzy. I can provide a higher resolution graphic if you tell me what size and format it should be.

screen shot 2019-01-18 at 5 54 44 pm

Which icon would everybody prefer, the pixelated one or the more realistic one?

pickaxe

jakwings commented 5 years ago
transparent bg

like this?

jakwings commented 5 years ago

PNG format is okay. Are you suggesting a new icon for all platforms? The sizes needed for making an icon.icns file on mac are 16, 32, 64, 128, 256, 512, 1024. The realistic one is nice.

AlexMooney commented 5 years ago

When this is merged, can we get a new point release?

ryfactor commented 5 years ago

When this is merged, can we get a new point release?

Yep sure thing :)

andrewtweber commented 5 years ago

Without shadow

1024x1024-noshadow 512x512-noshadow 256x256-noshadow 128x128-noshadow 64x64-noshadow 32x32-noshadow 16x16-noshadow

andrewtweber commented 5 years ago

As much as I'd like the realistic one, I don't think the quality will look good for > 128px or < 64px so we should probably stick with the classic. I'll leave it up to your judgement if it looks better with or without shadow

andrewtweber commented 5 years ago

In hindsight it makes no sense for the shadow itself to be pixelated. So here's an updated version with the shadow.

16x16-shadow 32x32-shadow 64x64-shadow 128x128-shadow 256x256-shadow 512x512-shadow 1024x1024-shadow

jakwings commented 5 years ago

Could the shadow be lighter?

compare1 compare2 compare3 compare4

Although the banana looks smaller now and has a glow/blur effect, it is still too large when compared to the pickaxe. I prefer the completely solid one.

Then I tried to enlarge the realistic one to 256x256 (128x128@2x) with https://waifu2x.booru.pics/ It looks pretty good even when the Dock size is set to the largest.

The icns has been pushed to ci/osx/IVAN.app/Contents/Resources/realistic.icns 512x512 and 1024x1024 are not included since I'm not sure when they would be used.

The latest dmg: (icon is not dynamically set to the Icon.bmp when run) https://github.com/jakwings/ivan/releases/download/vTest2/IVAN-vTest2-osx.dmg

jakwings commented 5 years ago

and the one using the realistic icon: https://github.com/jakwings/ivan/releases/download/vTest3/IVAN-vTest3-osx.dmg

andrewtweber commented 5 years ago

After seeing both of them in action I think I prefer the pixelated one actually.

I do think it needs a bit of a shadow, I'll get you a copy of the icon with less shadow

I'll post a "poll" on the forum after the pixelated version is finalized

andrewtweber commented 5 years ago

How is this?

16x16 32x32 64x64 128x128 256x256 512x512 1024x1024

jakwings commented 5 years ago

Yeah, I have no problem with the one with less shadow.

+1 for both the pixelated & the realistic.

now I know that 512x512 (256x256@2x) is for the Finder pop-up window for preview

jakwings commented 5 years ago

Two demos for trying out the icons: https://ipfs.io/ipfs/QmQtxPa5PGQE1FZCQMWrTQLFF6RWmopvjNeUFGPSAvC1Rw

Demo.app/
└── Contents/
    ├── Info.plist
    ├── MacOS/
    │   └── play
    ├── PkgInfo
    └── Resources/
        └── ivan.icns
andrewtweber commented 5 years ago

Added a poll here:

https://attnam.com/topics/Preferred-icon-for-game-releases

andrewtweber commented 5 years ago

@iology it's overwhelmingly in favor of keeping the pixelated icon (only 5 votes but.. that's about all we can hope for). Also sounds like the modern one may have been specifically made for the website. Let's go with pixelated.

jakwings commented 5 years ago

Rebased and cleaned up the commit messages.

So this icon is for all platforms. Note that this is a PR for mac only.

andrewtweber commented 5 years ago

Looks good to merge but I'll let @fejoa take a look first as well as see what needs to be done for Windows icon to match with the slight shadow

ryfactor commented 5 years ago

@andrewtweber excellent, I'll look into it. What are your settings for the drop shadow?

andrewtweber commented 5 years ago

Oof I don't remember.

What format does Windows use, ICO?

Any way to just combine the PNGs above into layers? Or does it need a size that we don't have

ryfactor commented 5 years ago

Yep Windows just uses the ICO format. I just save your 256x256 png and open it in GIMP. Using GIMP I can create a variety of sizes from the largest windows size (256x256). For some reason the drop shadow goes away, but I can set it up again in GIMP and it will be preserved in the export to the .ico format.

EDIT: Almost got something working, just need the info about the drop shadow. Preferable an x-offset, y-offset, blur radius and opacity, all measured in pixels... :fearful:

andrewtweber commented 5 years ago

Hmm, you should be able to just paste the individual files above as layers. Does this work?

https://drive.google.com/file/d/1HFo7XGudu5LUeS4vzOk2jF31oA8XPBh4/view?usp=sharing

ryfactor commented 5 years ago

Thanks Andrew, I'll download those tomorrow and make the ICO.

andrewtweber commented 5 years ago

The google drive file I linked to in the previous comment is an ICO :) Has all sizes from 16x16 to 256x256. Should’ve just made it for you in the first place

ryfactor commented 5 years ago

Excellent, thanks Andrew. I did open it for a look and found it didn't have the 48x48 pixel size needed for windows, so I added that in. It seems like the drop shadow has been preserved throughout the processing.

I added the ICO file in #533. In a hideous twist, it seems like Windows caches the old icon, so existing players might not see the updated icon if they add a shortcut to IVAN for example to their desktop folder. If they access IVAN from its own folder, then I think it will simply display our new icon :)

EDIT: Since the new ICO has the same name as the old, no further changes are needed to Ivan.rc. The build system will therefore take care of everything.