search

Attnam / ivan

Iter Vehemens ad Necem - a continuation of the graphical roguelike by members of http://attnam.com
GNU General Public License v2.0
305 stars 42 forks source link

(ready) Aslona #576

Closed red-kangaroo closed 4 years ago

red-kangaroo commented 4 years ago

Adds a new main quest in the kingdom of Aslona, plus assorted bugfixes and changes (sorry, I know they would be better as separate PRs).

To stop new quests from always requiring the dev to deal with the encrypted scroll, I changed the way quests are activated. Now you always need to talk to Petrus first to give him the scroll, and then you can choose to talk to other quest givers for new quest. To activate GC, just talk to Petrus again; talk to the necromancer for TX and to Sir Lancelyn for Aslona.

See NEWS for more details on the changes.

lgtm-com[bot] commented 4 years ago

This pull request introduces 4 alerts when merging a0241e59df1cb4936366759c4edc2c046ce07c75 into 4bdf1a9bfe9b526d322b3ac414d6c0b0c7655c78 - view on LGTM.com

new alerts:

red-kangaroo commented 4 years ago

Test release can be found here. :)

ryfactor commented 4 years ago

I see you have cheekily named it 0.58 :)

lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert when merging 929417b73735a42f410cbd27f2331e010784c338 into 4bdf1a9bfe9b526d322b3ac414d6c0b0c7655c78 - view on LGTM.com

new alerts:

AquariusPower commented 4 years ago

I saw the tip about IVANX having 3D, I didnt know/remember that! I tested it and both the 3D 1st person and the isometric seems to be working fine (no glitches on the initial steps in town at least), despite it is slow here (linux+WineHQ). Here the links I found: https://www.linkdata.se/sourcecode/ivanx/ https://sourceforge.net/projects/ivanx/files/Win32%20binary%2C%20zipped/0.60.3/

To merge this, I think the easiest way would be to create a diff from "equivalent" vanilla IVAN of that time, and apply the resulting patches manually on the newest code here. As I remember it was not too hard to do for IVAN3D.

red-kangaroo commented 4 years ago

@AquariusPower Definitely not for this PR, it's already huge, but yeah, it would be nice to have the 3D/isometric options.

red-kangaroo commented 4 years ago

I think this PR is ready, unless someone has found bugs I haven't yet fixed. :)

ryfactor commented 4 years ago

@red-kangaroo does this PR make #569 redundant? If so, then I can close #569.

red-kangaroo commented 4 years ago

@fejoa Yes, I added your new graphics and the ones from CLIVAN. :)

ryfactor commented 4 years ago

@red-kangaroo cool, always good to tidy up :)

ryfactor commented 4 years ago

I'd like to reaffirm my approval.