unable to craft a round key (also in case is ends up broken)

[AquariusPower]

using 30cm3 of balsa wood

error: "Undefined key configuration #2176 sought!"

stack (a screenshot as show the values from nemiver:

the round key numeric id seems to be "ROUND_LOCK with value 2048" (instead of 2176?) on the definesvalidator.h I will try to re-generate it to check.

[AquariusPower]

The developer console (ctrl+`) seems broken? (I couldn't understand why it broke yet) so, on this branch https://github.com/AquariusPower/ivan/tree/SomeFixes1234 I exposed some developer commands thru command line ./ivan --defgen ./ivan --defval to generate and validate the definesvalidator.h (also updated it and updated the documentation about these new cmdline params)

about the crafting key problem but... I saw no problem (when validating defines) related to the round key item creation... anyway, now I can craft the keys (dont know why), but... it is crashing in case the key breaks during its crafting now!

[red-kangaroo]

I can confirm that dev console segfaults when I try any command.

BTW, @AquariusPower what can it do? :) I must confess I've never used it, and I'm curious.

[AquariusPower]

it was used to generate and validate the defines (but now it can be just an OS command line),

but also it could list items and NPCs/Player/Pets on the current dungeon level,

and set debug variables that could be placed anywhere in the code for more specific tests (I think I never used this tho, so not sure it is correctly working),

obs.: devcons::OpenCommandsConsole()

[AquariusPower]

I can confirm that dev console segfaults when I try any command.

I got a stack trace that shows strings gets messed after certain point in the code, I couldnt understand what happened, I will create another issue for this with that stack trace from nemiver.

[AquariusPower]

Fixed crafting keys in case it ends up broken. I saw at item.dat that there is no BROKEN config for keys (that now CanBeBroken), that was the problem. The fix begin at item.cpp:SetConfigIfPossible() at https://github.com/AquariusPower/ivan/tree/SomeFixes1234

[red-kangaroo]

Oh, I can see what the problem might be. Keys sometimes break, but they are destroyed when they do, they don't become broken, thus no BROKEN config. However, crafting apparently defaults to BROKEN item if the item can be broken?

[AquariusPower]

thats it, if it CanBeBroken it tries to use the |BROKEN config otherwise we get just a lump. btw, it would be interesting to also let keys burn as we can craft them with wood :>