(See the other PRs first!) This is the merge of all my other PRs + some fixes and adjustments.

[AquariusPower]

This was split on several PRs, but there is still code here that are not on them, so, let this be the last PR considered.

---

I think this is overall ready, I made some basic tests during implementations, and let it for hours on auto-play mode (but it does not test everything/flow). What is mainly missing is more tests on normal gameplay.

Many new things:

• Lights (ready?): Weaker lights from small rocks feels ok now, but it would be better more extensive testing (ex.: crafting daggers from crystal rocks) before changing/removing the related default (disabled) option.
• new sfx (ready): New sfx for cutting webs, is it ok? (also cutting will provide a bit of spider silk lump)
• crafting skill progress (ready),
• CustomMoveKeys(ready?): not only move keys, all keys now can be customized but not in-game, the cfg file must be edited (after it is generated in game, somewhat complex for now...)
• ItemInfo(ready?): https://github.com/Attnam/ivan/issues/588 (is it working well?)
• GodFavours(ready?): https://github.com/Attnam/ivan/issues/586 (should I move some other pray effect to favour?)
• Crafting(ready): basic/simple tailoring added (TODO one day with graphics: (Done)tailoring bench 3x requirements of building a workbench; sewing thread should drop from webs instead of spider silk lump; as tools should have scissors and needles and pins crafted from meltables, all with graphics). Will work with any CAN_BE_TAILORED material.
• Independent SFX volume control (ready)
• Auto drop item after Offering it at an altar (in case it is rejected) optional (ready)

Bugfixes (some may only happen when using Wizard Auto Play mode):

• Fixed: last know god's relation also works now for Pray() and Favour() (ready)
• Fixed: MIDI transition leaving wrong instrument note state (ready?)
• Fixed: rare SIGFPE at character::TakeHit(), and crash of scrollofearquake at SpiderNest dungeon level (from AutoPlayMode).
• Fixed: Also, fixed it when crafting a key that breaks (or anything else that has no BROKEN configuration on .dat files) see https://github.com/Attnam/ivan/issues/582
• Workaround: bitmap::DrawLine() crash see https://github.com/Attnam/ivan/issues/590
• fixed some random crashes in some places (see commit log)

And command line --help with some info and functionalities: --defgen Generate defines validator source file. (NEW) --defval Validate defines. (NEW) --version Show current game version.

Who have access to edit this PR, feel free to make any adjustments, even if minor.

Obs.: developer console is still broken tho but wont cause trouble if you dont use it. developer console is working again! I think cuz of this: https://github.com/Attnam/ivan/pull/589 :)

[AquariusPower]

Hi! I am having some trouble here... It's about a few weeks now that my refrigerator broke (this means I got out of spare time), but all about it is already better now. But a few days ago my main computer broke! now it will be complicated to implement/test things...

My guess is that you would like to prepare a release before christmas right? I am not sure I will be able to prepare the requests til that time... But I can review and give tips on any adjustments anyone may be willing to prepare. You can create a PR to my branch if you can't edit it directly here. I will only be able to read tho, not to test it. :>

[ryfactor]

Hi! I am having some trouble here... It's about a few weeks now that my refrigerator broke (this means I got out of spare time), but all about it is already better now. But a few days ago my main computer broke! now it will be complicated to implement/test things...

My guess is that you would like to prepare a release before christmas right? I am not sure I will be able to prepare the requests til that time... But I can review and give tips on any adjustments anyone may be willing to prepare. You can create a PR to my branch if you can't edit it directly here. I will only be able to read tho, not to test it. :>

Hi @AquariusPower! Sorry for the late reply. I am very sorry to hear your refrigerator broke down, and even sorrier to learn your computer broke. Good on you for getting in touch, I hope you are going ok and are able to get all the machines you need to get back on track. Probably that refrigerator is top priority. In the meantime, TravisCI is no more, so I am plugging the gap just now with some GitHub Actions. I'll try and get some Linux builds going on pull-request so things can seem as they were before.

[red-kangaroo]

Oops, sorry @AquariusPower

I pushed some of my changes, but I thought I was pushing into my own fork of your branch, not directly into your branch. Strange that git let me...

[AquariusPower]

Oops, sorry @AquariusPower

I pushed some of my changes, but I thought I was pushing into my own fork of your branch, not directly into your branch. Strange that git let me...

the spell I cast on OP "Who have access to edit this PR, feel free to make any adjustments, even if minor." apparently worked xD