search

Attnam / ivan

Iter Vehemens ad Necem - a continuation of the graphical roguelike by members of http://attnam.com
GNU General Public License v2.0
297 stars 42 forks source link

lgtm fixes #589

Closed ryfactor closed 4 years ago

lgtm-com[bot] commented 4 years ago

This pull request fixes 6 alerts when merging 1a1db761ad3c99e7f7ac846b83beb9f8ed0fb7d8 into 87f4a33fc84e8b3b432c9db4211c3d213433cc98 - view on LGTM.com

fixed alerts:

AquariusPower commented 4 years ago

now I get why I am getting most of the lgtm messages at https://github.com/Attnam/ivan/pull/587

It was conflicting, couldnt auto merge dont know why, so I copied these changes at that branch, created a new macro (with 15 params), but whenever I try to merge your branch with mine, it keeps aiming at an older repository commit of my branch... I dont get it... https://github.com/AquariusPower/ivan/compare/SomeFixes1234...fejoa:lgtm-fixes

ryfactor commented 4 years ago

but whenever I try to merge your branch with mine, it keeps aiming at an older repository commit of my branch... I dont get it...

I don't get it either. Oh well, it's not very much code to copy over. Funny how the compiler complained about this commit when the wizard mode flag was set... I must have overlooked something. Anyway, the code you put into #587 seems to have done the job :)

ryfactor commented 4 years ago

Oh! Wait it's this line here: https://github.com/Attnam/ivan/pull/589/files#diff-28236a94b2b7ad44dd69f1be93655df6R324 For which you added DEVCMDMSG15 lol!

AquariusPower commented 4 years ago

Oh! Wait it's this line here: https://github.com/Attnam/ivan/pull/589/files#diff-28236a94b2b7ad44dd69f1be93655df6R324 For which you added DEVCMDMSG15 lol!

I am not sure, but it could be something new I coded here :> https://github.com/Attnam/ivan/blob/ed7f7ab114bf9b8f5be5e910bef3d9bcd4eb81ad/Main/Source/devcons.cpp#L184 I thought DEVCMDMSG11? no.... 15 and put dummies on it's call xD

ryfactor commented 4 years ago

Great. I guess we can Close #589