search

Attnam / ivan

Iter Vehemens ad Necem - a continuation of the graphical roguelike by members of http://attnam.com
GNU General Public License v2.0
306 stars 42 forks source link

Craft Skill and other related things #595

Closed AquariusPower closed 3 years ago

AquariusPower commented 4 years ago

It has also a fix for crafting something that breaks and has no config at .dat files. (cherry pick from https://github.com/Attnam/ivan/pull/587)

AquariusPower commented 4 years ago

this should receive an update I didnt mange yet to bring from https://github.com/Attnam/ivan/pull/587 about a chance of gaining craft skill every craft turn on long lasting crafting tasks.

red-kangaroo commented 4 years ago

@AquariusPower One thing I noticed in #596 : When splitting rocks with no appropriate tool, the game tells you that you need a cutting tool, but you actually need a hammer.

red-kangaroo commented 4 years ago

Could we get reorganized skill overview? Right now, it says "Your experience in weapon categories"/"battle bonus", and then lists crafting. :)

There's crafting skill in the @ menu, and then crafting proficiency in F menu. Does crafting skill increase your crafting proficiency?

When crafting from ingots, they are instantly transformed to lumps if you cancel the crafting after selecting materials but before beginning the crafting action. They should only get lumped if you start crafting and then fail/stop.

What if you could craft any furniture, even if they don't do anything? Maybe the player wants to build a small house with some beds and an oven.

Spider silk from webs is a great touch. :)

AquariusPower commented 4 years ago

@AquariusPower One thing I noticed in #596 : When splitting rocks with no appropriate tool, the game tells you that you need a cutting tool, but you actually need a hammer.

if I am not wrong, I initially thought and coded it like: to split a rock you would need a dagger and a hammer, so that you would aim the dagger on the rock and hit the hammer on the dagger's hilt. But the warn/user/help message may be imprecise!

AquariusPower commented 4 years ago

Could we get reorganized skill overview? Right now, it says "Your experience in weapon categories"/"battle bonus", and then lists crafting. :)

The skill progress system was already implemented as weapon skills, it just took me some more time than usual to realize that xD

There's crafting skill in the @ menu, and then crafting proficiency in F menu. Does crafting skill increase your crafting proficiency?

in the F menu (that is a good and innocent menu, just meaning craFting xD), so it works like this: You have the craft skill, that increases with each related action. You have a crafting bonus based on your stats (mainly dexterity). On that special menu, the crafting value shown is: CraftSkill+CraftBonus Btw, craft bonus now begins in 0 if you have all stats in 10, what is an incentive to develop the craft skill. (I think there is a limit tho, the final value is never less than 1)

When crafting from ingots, they are instantly transformed to lumps if you cancel the crafting after selecting materials but before beginning the crafting action. They should only get lumped if you start crafting and then fail/stop.

Agreed! and the way it is now it is quite annoying/unfair... But to let it work properly, it would require a quite more complex code (I guess), or... I just thought it... we could implement an "UNDO" code, that would join the lump back into the ingot if the crafting action doesnt really begin. Cutting the ingot (or any other crafting basic item) and creating the lump is a preparation to the crafting process but it should be undone if that isnt started!

Cool, I think an UndoCraftingPreparation() could be a good workaround! May be, the new cut ingot and the new lump could be just deleted and the old one could be just restored, I dont know yet the best way to implement it tho.

What if you could craft any furniture, even if they don't do anything? Maybe the player wants to build a small house with some beds and an oven.

Nice! it would open a menu listing them all, may be the useful ones on the top. The problem is the volume of materials required to build them. May be all "non useful" could have a default small value, may be 2000cm3, or we could add a property on the .dat file related to furniture, something like: ToCraftVolumeRequired = 2000, that being default, but later we could specify each, and it would be better.

Spider silk from webs is a great touch. :)

Used in tailoring as sewing material, but we can craft gloves etc from it too, yep it is fun. After that I avoid killing spiders to let them create webs I can collect. Btw, in my house irl, I get all these inoffensive spiders and put them on the plants to help fighting insects, inoffensive spiders are very cool! xD

ryfactor commented 3 years ago

It compiles and runs on Windows. I haven't tested anything but it seems to work OK. Can we merge this yet?

ryfactor commented 3 years ago

I would like to merge this next. I think it is ok @red-kangaroo ?