Attnam / ivan

Iter Vehemens ad Necem - a continuation of the graphical roguelike by members of http://attnam.com
GNU General Public License v2.0
305 stars 42 forks source link

DEFINITE or INDEFINITE, the bits look wrong? #607

Open AquariusPower opened 4 years ago

AquariusPower commented 4 years ago

I was doing some conversions to bits (to add new bits like UNLABELED and NOPOSTFIX etc), and found that INDEFINITE has the DEFINITE and ARTICLE_BIT (also why both are the same?), are they clashing? does this looks right?

-#define ARTICLE_BIT 2
-#define DEFINITE 2
-#define INDEFINE_BIT 4
-#define INDEFINITE 6
+#define ARTICLE_BIT  0b00000010
+#define DEFINITE     0b00000010
+#define INDEFINE_BIT 0b00000100
+#define INDEFINITE   0b00000110

All code using them could be messed or I am just wrong? and... I would like to be wrong :)