search

Attnam / ivan

Iter Vehemens ad Necem - a continuation of the graphical roguelike by members of http://attnam.com
GNU General Public License v2.0
306 stars 42 forks source link

Auto store items on container based on inscribed regex #608

Open AquariusPower opened 4 years ago

AquariusPower commented 4 years ago

just inscribe a regex in the container works for pickup and auto-pickup (split from https://github.com/Attnam/ivan/pull/587 using meld folder compare)

AquariusPower commented 4 years ago 
* The message for storing an item in a container should come after the message for picking it up:

agreed, if to move the code (that stores the item) becomes too complicated, just moving the message (store it in a var to display later) would suffice.

* Items will be stored in containers even when they are locked. There should be a check if you can open the container before trying to auto-store an item inside.

could check if it is locked, and then store only if we have a key to open it. To complement that, we should let NPCs get items from unlocked containers making keeping it locked meaningful. In the other hand, we could grab a locked chest and using this glitch/bug, store things on it w/o having a key.

red-kangaroo commented 4 years ago

To complement that, we should let NPCs get items from unlocked containers making keeping it locked meaningful.

That would be nice.

In the other hand, we could grab a locked chest and using this glitch/bug, store things on it w/o having a key.

I would consider that bug abuse. :D Also the player might end up with items stored in chests he doesn't have a key for.

ryfactor commented 2 years ago

Are we good to merge this @red-kangaroo ?

red-kangaroo commented 2 years ago

Are we good to merge this @red-kangaroo ?

I think there should at least be the check not to store items in locked containers. That could bite the player in the proverbial ass quite easily. :)

I will try having a look at that, maybe during holidays.