search

AttorneyOnline / AO2-Client

An off-the-cuff courtroom drama simulator
https://aceattorneyonline.com
GNU General Public License v3.0
61 stars 58 forks source link

Change the default theme to AceAttorney #1030

Closed stonedDiscord closed 3 months ago

Salanto commented 3 months ago

Are you sure we should change it in client instead of just swapping the theme files in the theme repo?

stonedDiscord commented 3 months ago

I've considered it but it will mess with users who upgrade. I'd prefer if the theme doesn't suddenly change for existing users who are on the default theme and like it. This change will basically only affect users who don't have a config.ini yet (or deleted it)

Salanto commented 3 months ago

I just looked over the functions using default_theme are pathing related, so this might break if AceAttorney does not include all elements the default theme provides (like for effects). Otherwise yeah, it would be fine.

stonedDiscord commented 3 months ago

Yeah, I'll move the files over later today.

stonedDiscord commented 3 months ago

https://github.com/AttorneyOnline/AO2-Themes/pull/20

Salanto commented 3 months ago

Just tested this, it will jack up the default theme either way since default contains few items, which will then be loaded from AceAttorney.

Salanto commented 3 months ago

LGTM