Closed in1tiate closed 4 months ago
You may still want to wait for someone else to review this too cause that looks a bit too large for single approval.
experiencing a bizarre frame effects bug, will check on it tomorrow
Fixed, PR is review and merge ready.
ah. Stand by
Closing, rebased manually on a different branch, see https://github.com/AttorneyOnline/AO2-Client/pull/966
Refactor of https://github.com/AttorneyOnline/AO2-Client/pull/869, now with 70% fewer merge conflicts.
Took the old code verbatim and added pair support,. As far as my testing shows, this kinda just works.
Formatting required for setup:
Full courtroom image (should be named "court.png" but can work with any name) Design.ini parameters:
where "court:pos" is the main image and the name of its subposition.
pos_center
is the pixel position of the center of the part of the image you want to be a position and the transition duration settings are formatted asslide_ms_pos
and a duration in milliseconds.Additionally, there is support for giving characters a special pose during transitions if an "Objection!" shout was used.
This PR also adds a checkbox to the main UI to enable or disable sending the new MS parameter
SLIDE
which dictates whether a message is able to trigger a slide animation.Additionally, a global setting is now in the settings menu to disable slide animations for yourself.