AttorneyOnline / AO2-Client

An off-the-cuff courtroom drama simulator
https://aceattorneyonline.com
GNU General Public License v3.0
63 stars 58 forks source link

Add streaming brush for songs in musiclist #963

Closed UnDeviato closed 1 month ago

UnDeviato commented 1 month ago

I simply added a fake extention (.music) so that client can understand if title of the song is a category or a song in the musiclist

This is how it should work the musiclist for streaming music (I'm using yaml and not json file ) Screenshot 2024-05-18 124204

TrickyLeifa commented 1 month ago

Frankly this should be a flag when providing information about the music list. Adding a hardcoded suffix is definitely not the way to go...

Since I'm going to be reworking the network, may as well just make it a flag to figure out whatever a song is local or streamed to reach the same effect you had wanted without applying hardcoded change.

UnDeviato commented 1 month ago

I agree I was thinking the same thing, also in my opinion when server sends to client the musiclist, there should be another way to set categories and songs. (Right now it simply check if an element has an extention, so I cannot insert streamed song in the musiclist without adding a fake extention)

Btw this PR can be closed for the moment