AttorneyOnline / AO2-Client

An off-the-cuff courtroom drama simulator
https://aceattorneyonline.com
GNU General Public License v3.0
61 stars 59 forks source link

Remove or redesign "ghost" messages #972

Open TrickyLeifa opened 4 months ago

TrickyLeifa commented 4 months ago

Ghost messages are a "feature" that was recently added, unfortunately this "feature" also exemplify a good deal of why it is very poorly designed. First is code complexity, the amount of code that was changed (especially logs) to accommodate the supposed feature is a cruel mistake. The code is very shoddy and so poorly implemented you have to use a magnifying glass and a PHD in natural science to figure out the intention of some of it.

The very fact that the 'Instant Objection' toggle can completely bypass the ghost message is horrendous. Additionally, the fact there can be multiples ghost messages queued after another, which completely defeats the purpose of the system which is meant to relay to the user that ONE other user already spoke and that their message is on the way is idiotic at best and completely insane at worst. If everyone can queue their message anyway with a system that is meant to control the flow of messages it's completely and utterly useless.

collinxchu commented 3 months ago

Personally, I would redesign it to work like so:

Messages are coming in to the client > The client types a message and hits enter > Text input is disabled/greyed out/otherwise made clear you cannot hit enter again > Client waits for their SINGLE message to be processed > Text input is enabled/not greyed/etc.

This preserves the "you don't have to hold down enter" behavior, keeps the incoming queue, and solves the issue of compounding chat noise via multiple outbound messages.

stonedDiscord commented 2 months ago

I vote remove