search

AttorneyOnline / akashi

C++ AO2 Server
GNU Affero General Public License v3.0
4 stars 23 forks source link

Check for doubleposts per client, not per area #338

Closed in1tiate closed 7 months ago

in1tiate commented 8 months ago

Doing it per area neutered a lot of jokes, and was kind of awkward. Per client feels a lot more natural, and still serves to prevent spam about as well.

codecov[bot] commented 8 months ago

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (master@18719c9). Click here to learn what that means. Report is 3 commits behind head on master.

Files Patch % Lines
core/src/packet/packet_ms.cpp 0.00% 7 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #338 +/- ## ========================================= Coverage ? 12.78% ========================================= Files ? 56 Lines ? 4755 Branches ? 0 ========================================= Hits ? 608 Misses ? 4147 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

in1tiate commented 8 months ago

Also removed a redundant check. If the last message from the client isn't empty, and it matches the message we're checking, it stands to reason that the message we're checking also isn't empty.