AttorneyOnline / tsuserver3

An Attorney Online server.
GNU Affero General Public License v3.0
25 stars 51 forks source link

CM in another room shows IC showname as 0 #150

Closed caleb-mabry closed 3 years ago

caleb-mabry commented 3 years ago

Steps to replicate

Actual Behavior: CM will see the message but the users showname is listed as 0

Expected behavior: CM will see the show name with the room number in grey brackets before the message

Left client is the user and right client is the CM image

caleb-mabry commented 3 years ago

Alright, so it looks like the issue is found in the send_owner_command method. An example command

I'll include the cmd, *args and how it is built and sent to the CM

MS 1 - Young Mia normal This is a broken packet [BAS]This is a broken packet def 1 0 49 4 0 0 0 0 0  -1   0 0 0 0 0 0 -^(b)normal^(a)normal^ -^(b)normal^(a)normal^ -^(b)normal^(a)normal^ 0 ||
MS#1#-#Young Mia#normal#This is a broken packet#[BAS]This is a broken packet#def#1#0#49#4#0#0#0#0#0##-1###0#0#0#0#0#0#-^(b)normal^(a)normal^#-^(b)normal^(a)normal^#-^(b)normal^(a)normal^#0#||#%
caleb-mabry commented 3 years ago

I think I've found the issue and I'm putting in a PR for it