AuDigitalHealth / ci-fhir-stu3

Working drafts of HL7™ FHIR® Release 3 (STU) artefacts authored and maintained by the Clinical Informatics team at the Australian Digital Health Agency.
Other
11 stars 0 forks source link

Advance Care Directive Custodian Record Composition profile has bugs in 2 invariants using FHIRPath 'conformsTo' #56

Closed robeastwood-agency closed 4 years ago

robeastwood-agency commented 4 years ago

Prerequisites

The bug

In the Advance Care Directive Custodian Record composition profile (composition-acdcr-1), the invariants on the following 2 extensions have faulty FHIRPath expressions, related to the use of 'conformsTo'. The consequence of which is that acceptable content for these elements always fails to be valid against these invariants.

1) Element: Composition.extension:compositionAuthorRole

What I expected to happen

Acceptable content for this element shall be valid against these invariants. Unacceptable content for this element shall not be valid against these invariants.

The fix

The correct (and simplified) FHIRPath is (respectively):

valueReference.reference.resolve().conformsTo('http://ns.electronichealth.net.au/ci/fhir/3.0/StructureDefinition/practitionerrole-withpractitionerident-1')
valueReference.reference.resolve().conformsTo('http://ns.electronichealth.net.au/ci/fhir/3.0/StructureDefinition/relatedperson-ident-1')

Screenshots

N/A

Workarounds

N/A

QA.html excerpt

N/A

Desktop (please complete the following information):

N/A

Additional context

N/A

RichardTON commented 4 years ago

After product owner meeting: agreed changes to invariants and supporting information with PO 1) invariants on attester merged and changed to current style 2) invariant inv-dh-cmp-10 on section deleted 3) invariant inv-dh-cmp-07 on authorRole deleted 4) copyright updated to 2020 5) usage scenarios and implementation guidance updated 6) use 1.1.1 of aubase for dependencyList.version in ig-advancecarerecords-1.json

RichardTON commented 4 years ago

Reviewed changes with PO and sent for review

RichardTON commented 4 years ago

After review made the following changes

  1. set implementation guidance to "TBD"
  2. corrected some relative paths in invariants
  3. corrected description of invariant about profile
  4. reordered some invariants
  5. added reference invariant to attester.party
RichardTON commented 4 years ago

Merged into master, rebuilt and pushed to GitHub. [adc5db0]