AuDigitalHealth / ci-medicare-records

Working drafts of HL7™ FHIR® artefacts authored and maintained by the Informatics Architecture team at the Australian Digital Health Agency that represent atomic Medicare records in the My Health Record system and related applications.
Other
1 stars 1 forks source link

ExtensionDonationDecision :: erroneous slicing on value[x] #20

Closed dtr-agency closed 2 years ago

dtr-agency commented 2 years ago

Prerequisites

The bug

Probably caused by tooling limitations at the time, but the extension includes a slice for value[x] that is not required; instead the extension can simply constrain the type. For example, in an instance of ExtensionDonationDecision:

          "id": "Extension.value[x]",
            "path": "Extension.value[x]",
            "slicing": {
                "discriminator": [{
                    "type": "type",
                    "path": "$this"
                }],
                "ordered": false,
                "rules": "closed"
            },
            "short": "Value of extension",
            "definition": "Value of extension - may be a resource or one of a constrained set of the data types (see Extensibility in the spec for list).",
            "min": 1,
            "max": "1",
            "base": {
                "path": "Extension.value[x]",
                "min": 0,
                "max": "1"
            },
            "type": [{"code": "dateTime"}],

Suggest removing the slicing and adding a constraint on the value.type instead. This change should not have any normative impacts but it is an improvement in terms of processing requirements and implementing correct profiling practices. 

dtr-agency commented 2 years ago

In review and testing with @dbojicic-agency via https://jira.digitalhealth.gov.au/browse/AN-470.

dbojicic-agency commented 2 years ago

Confirmed change; no further issues found.