search

AuScope / seed-vault

Other
2 stars 0 forks source link

implement final continuous download step #135

Open filefolder opened 1 week ago

filefolder commented 1 week ago

I think this is the last thing that needs doing, at which point we have a working beta I can start sharing the program with people.

If it can be done today, I can present this tomorrow in our seismology meeting.

laughing0li commented 1 week ago

@filefolder I've pushed the new version with continuous download step. pls try.

filefolder commented 1 week ago

thanks! however there need to be separate filters for the requests, currently it just assumes the same range as in the station search. this is a particular problem because the endtime for stations is typically "None" which can default to the year 2099 or later. what happens is the loop will go on forever and in my case memory wasn't getting freed and it crashed.

the output messaging was also ill formatted as there are no line breaks (the CLI version handles this naturally so I never noticed). I have pushed a small change to insert a line break.

laughing0li commented 1 week ago

@filefolder I've add the date filter to the continuous data page.

filefolder commented 13 hours ago

thanks.. I think this will still need to have all of same waveform filters as in the other steps (e.g. network, station, location, channel) even if they are theoretically redundant at this point because people need to know what it is they're about to download. these should have the same appearance as well for consistency. see also #158