AuScope / seed-vault

Other
2 stars 0 forks source link

limit maximum request time in get_waveforms #140

Closed filefolder closed 5 days ago

filefolder commented 1 week ago

just discovered an interesting way to lock up my computer's memory: setting the "endtime" for a continuous request far into the future (e.g. None). requests will just go on forever, memory wasn't being freed, and ultimately the server experiences a minor DDOS.

this is fine for get_events and get_stations, but the end time for a waveform request should be min(t, now-60) (a minute before now is usually safe; servers will have their own parameters to limit this)

would also need a catch to delete a request if the starttime is sooner than a minute ago

filefolder commented 5 days ago

completed