Scoreboard problems fix - Githubissues

AuburnACM / auacm

The Auburn ACM Website

Apache License 2.0

15 stars 3 forks source link

Scoreboard problems fix #46

Closed WilliamHester closed 8 years ago

WilliamHester commented 8 years ago

Make sure everything looks good here. I think it's pretty solid, but I also wasn't able to drive when I wrote this code. Fixes #40.

BrandonLMorris commented 8 years ago

Ok, I haven't gotten a chance to run it, but so far it looks good. Just a few things I wanted to point out:

_Should Fix_

[x] I think you're behind master. Not sure if you were waiting to merge it in.
[x] .keys() isn't necessary to iterate over a dictionary
[x] Not sure about some of the names in the ScoreboardController

_If You Feel Like It_

The get_competition_data method is a bit complex. I don't know how, but it might could benefit from being broken up some.
On a similar note to ^, the create_competition_object may fit better in the models.py file as a method on the Competition class.