Create competition date

AuburnACM / auacm

The Auburn ACM Website

Apache License 2.0

15 stars 3 forks source link

Create competition date #49

Closed WilliamHester closed 8 years ago

WilliamHester commented 8 years ago

This does about half of what's required for the pull requests, as it does not allow the creation of teams or registering for a competition as a user. That still needs to be fixed; I'm not sure what the best route is, but I have some ideas for it (hello, table joins).

BrandonLMorris commented 8 years ago

Cool stuff. I haven't gotten a chance to run it (my terminal is on the fritz, I'm not sure why) but I'll try it soon so we can get this through.

_Needs to be Addressed_

[x] Asking for forgiveness instead of permission in Python (picky)
[x] Decide how we check undefined variables in JavaScript
[x] Substring labels (this probably falls under validation, which you explicitly said you're not doing. Sorry)

_Additional Remarks_

Doing form validation with Angular directives is cool, we should look into the (dis)advantages of doing that across the board.
Cost/benefit of combining competition creation/editing.
Right now the client picks the labels for problems. To play devil's advocate, why doesn't the API just assign labels based on the order in the problem list?

WilliamHester commented 8 years ago

Looks like I addressed everything. As for the last 2 additional remarks,

It looks like the competition creation/editing is combined, unless you're talking about on the Python side.
The API doesn't assign labels because in the near future, we'll be able to arrange the problems in the order that we want for a competition. If we want to change to a number for order, that's possible as well, but it doesn't make a huge difference to me.

BrandonLMorris commented 8 years ago

Ok, I think I see: we're explicitly defining the order using labels rather than implicitly ordering them by the problem list. Correct?

WilliamHester commented 8 years ago

Correct.

BrandonLMorris commented 8 years ago

In that case, could/should we make labels an optional parameter, and the API can set some arbitrary default if the user fails to provide it? It may not be worth the trouble.

WilliamHester commented 8 years ago

I think that, for now, they should be required. If we decide in the future to allow a client not to specify them, then we can handle that then.

BrandonLMorris commented 8 years ago

Works for me.

BrandonLMorris commented 8 years ago

So setting the time of a competition uses a 24hr clock, right? Can you put a comment or something there so that the user can see that? Or maybe an additional dropdown that specifies AM/PM.