search

AuburnACM / auacm

The Auburn ACM Website
Apache License 2.0
15 stars 3 forks source link

Competition teams #54

Closed WilliamHester closed 8 years ago

WilliamHester commented 8 years ago

Allows creation/modification of teams for competitions. Fixes #24 and fixes #25 when combined with #49. Merge #49 first, as this is based off of that.

BrandonLMorris commented 8 years ago

What does the closed field do? Does it just specify if a given competition is active? Is it necessary, or can it just be computed from start/end times?

The code to a competition needs to be updated to include it, if it's going to remain. Right now trying to create a comp in the app throws a SQLAlchemy IntegrityError saying that "'closed' cannot be null"

WilliamHester commented 8 years ago

The closed field is for competitions that can only have users registered by admins. It's really for a feature that hasn't been implemented yet but will definitely be implemented soon. I'm not sure why that error is being thrown (probably because I forgot to assign a value to it in the competition creation).

BrandonLMorris commented 8 years ago

You can create a default value for it in models.py, but you have to be a little careful about. You can see what I did in problem_manager/models.py

BrandonLMorris commented 8 years ago

Looks good. TIME TO BETA!