AuburnACM / auacm

The Auburn ACM Website
Apache License 2.0
15 stars 3 forks source link

Problem comp release #97

Closed BrandonLMorris closed 8 years ago

BrandonLMorris commented 8 years ago

Problems can now be associated with a competition and hidden from users until that competition begins.

Changes

This feature also includes unit tests. Because that should be a thing.

BrandonLMorris commented 8 years ago

That should have all the fixes. I went ahead and made it so that admins can see the unreleased problems. Without it, there wasn't any real way to add them to competitions (I'm not exactly sure what I was thinking).

WilliamHester commented 8 years ago

Alright, so hiding is working now, but I have one issue. If I create a problem and add it to the competition from the create-a-problem interface, it doesn't actually add it to the competition. If this is intended, then that's alright. Other than that, it seems to be working, so I'm good with merging it.

BrandonLMorris commented 8 years ago

That's not a bug, it's a feature

It's a known limitation. I can add it here or in another PR. Your call.

WilliamHester commented 8 years ago

I'm fine with leaving that functionality right now, because it says "Release with competition," not implying that it will be added to the competition.

If people complain, we can add that in the future.