AuburnSounds / Dplug

Audio plugin framework. VST2/VST3/AU/AAX/LV2 for Linux/macOS/Windows.
https://dplug.org/
Other
479 stars 32 forks source link

DPI-aware NSIS #824

Closed p0nce closed 7 months ago

p0nce commented 7 months ago

When using ManifestDPIAware true in NSIS script, the image given to MUI_HEADERIMAGE_BITMAP doesn't display right, whatever the DPI.

p0nce commented 7 months ago

Lots of good practice there: https://github.com/notepad-plus-plus/notepad-plus-plus/blob/2768cf5422e6a443e7ed043ddd21a961e5c9859d/PowerEditor/installer/nppSetup.nsi#L30

p0nce commented 7 months ago

OK so the BMP that comes with NSIS doesn't exhibit this wrong behaviour! (EDIT: yes it does) There is something interesting inside. nsis3-vintage.zip

Comparison of that BMP when re-saved with MSPaint, colors are then wrong, which could create the impression of bad resampling.

comparison

p0nce commented 7 months ago

Comparison of bitmap header in NSIS and MSPaint output:

p0nce commented 7 months ago

Learning after a good deal of investigation:

p0nce commented 7 months ago

Done.