search

Auctionator / Journalator

World of Warcraft addon. Keep track of your gold making on the AH, crafting orders and with vendors
https://www.curseforge.com/wow/addons/journalator
MIT License
10 stars 6 forks source link

After uninstalling the Auctionator addon, Journalator doesn't work anymore. #63

Closed cgsub closed 1 year ago

cgsub commented 1 year ago

It now cause the followig LUA error whenever I do something inventory related, in my case I opened a few JC gem bundles:

10x Journalator/Source/Utilities.lua:178: attempt to index global 'Auctionator' (a nil value) [string "@Journalator/Source/Utilities.lua"]:178: in function GetItemLocationFromGUID' [string "@Journalator/Source/Monitor/LootContainers.lua"]:346: in functionAddToLogs' [string "@Journalator/Source/Monitor/LootContainers.lua"]:54: in function <Journalator/Source/Monitor/LootContainers.lua:29>

And when I tried to open it using /jnr it didn't work and printed: Journalator: Unable to open display. The Display addon is disabled

I looked in the addon panel and saw that three addons pertaining to Journalator had a dependency on Auctionator. I'm not sure if this is normal as the addon is not listed as requiring Auctionator installed.

On a side note: I actually removed Auctionator after the new buy interface made me do too many wrong purchases. after a while you get used to always click the buy button that kind of constantly pop anyway when you buy something. To seldom end up realizing that you just paid some material ten time the price that you expected based on the first given price.

Buying often probably rendered me not careful enough. But still, the standard buy interface doesn't cause me this problem.

Edit:

After reinstalling the addon using Curseforge, it seems to work fine without Auctionator now.

plusmouse commented 1 year ago

Journalator requires Auctionator for the UI components. The error you got was still a bug, so that's fixed in the latest alpha, but Journalator (Display) will need Auctionator enabled to work.

Side note: The buy interface has the same number of confirms as the Blizzard interface, its just integrated into the Shopping tab instead. Or is the Auctionator buy interface missing a dialog somewhere?

cgsub commented 1 year ago

Side note: The buy interface has the same number of confirms as the Blizzard interface, its just integrated into the Shopping tab instead. Or is the Auctionator buy interface missing a dialog somewhere?

It's just the price given at first by the interface that can be misleading. For instance last time I bought 500 rousing earth at 53g each thinking they were still at around the given ~14g

That is my bad for not realizing that the global given price of ~25k was not right. However I believe that having that upfront unit price always updated like it is in the default buy UI would have helped.

plusmouse commented 1 year ago

That price issue should be fixed now (I've just moved the alpha with the fix to a release). There was an issue with the unit price appearing being really low in some scenarios.

cgsub commented 1 year ago

Alright that is great news, I was missing my shopping lists :)

plusmouse commented 1 year ago

As always, report if something goes wrong, there's usually a fix I can add 😄

plusmouse commented 1 year ago

I'm going to close this as Auctionator is an intended dependency of Journalator