Auctionator / Journalator

World of Warcraft addon. Keep track of your gold making on the AH, crafting orders and with vendors
https://www.curseforge.com/wow/addons/journalator
MIT License
10 stars 6 forks source link

Income from Mission Table (SL) missing, or I'm too blind to find it #78

Closed tflo closed 6 months ago

tflo commented 6 months ago

Most of my toons are still doing the SL Mission Table, even more so now in the end phase of DF. The price of Augment Runes is down, but Pet Charms are worthy as always, and also those Gold missions that now return a max of 25 gold or so are possibly still worth doing if you have Anima en masse.

I wanted to use Journalator to check how much I actually get per day/week from these Gold missions, but I can't find this income anywhere.

If I'm not blind as usual and it really isn't there, then please just log it under Loot or Quests, no need to create a separate category. Well, or make a "Miscellaneous" category and put it there along with any future uncategorized income.

plusmouse commented 6 months ago

Tracking this is difficult due to the necessity of waiting for/finding a mission with a reward worth tracking to determine the events that give the rewards.

Expanding: I only have 1 character with SL mission table missions, so my access is limited.

P.S. As this is old content it has been deemed a low priority for tracking.

tflo commented 6 months ago

The reason for my "or I'm too blind to find it" disclaimer was that I thought I remembered... but actually it was the Accountant Classic addon that tracks gold from missions:

Screenshot Screenshot of Wow at Mar 2, 2024 at 19_02_13-fs8.png Screenshot of Wow at Mar 2, 2024 at 19_02_13-fs8

I haven't yet checked what they are doing, and usually Accountant Classic is pretty flawed compared to Journalator, but it seems to work.

plusmouse commented 6 months ago

Yeah. I wanted to have per-mission records of the gold/items but that was tricky the last time I looked.

tflo commented 6 months ago

per-mission records of the gold/items

It's not a problem with the mission items, because the gold is recorded the moment I sell them to the vendor (gear items) or on the AH (Augment Runes). It's just the direct gold income from the gold missions that completely slips through.

plusmouse commented 6 months ago

Journalator-1.79-1-g0df3f76.zip

Try this build (backup your Journalator saved variables first) it should add the mission gold to the summary tab

plusmouse commented 6 months ago

I've got missions pending to test it myself, but you might have some sooner

tflo commented 6 months ago

Got this error:

5x Journalator/Source/AddToLogs.lua:6: bad argument #1 to 'insert' (table expected, got nil)
[string "=[C]"]: in function `insert'
[string "@Journalator/Source/AddToLogs.lua"]:6: in function `AddToLogs'
[string "@Journalator/Source/Monitor/MissionTables.lua"]:35: in function <Journalator/Source/Monitor/MissionTables.lua:10>

Locals:
(*temporary) = nil
(*temporary) = <table> {
 source = <table> {
 }
 tableType = 4
 missionID = 2189
 missionName = "Gormling Nibblers"
 money = 375
 time = 1709415020
 itemID = 0
 itemCount = 0
}
(*temporary) = "table expected, got nil"
plusmouse commented 6 months ago

This should fix that particular bug Journalator-1.79-1-g760a610.zip

tflo commented 6 months ago

Summary is empty now, with this error:

GetProfit.lua:302: attempt to perform arithmetic on field 'moneyIn' (a nil value) ```denizenscript 18x ...faceJournalator_Display/Source/GetProfit.lua:302: attempt to perform arithmetic on field 'moneyIn' (a nil value) [string "@Journalator_Display/Source/GetProfit.lua"]:302: in function `GetInOut' [string "@Journalator_Display/Source/DataProviders/SummaryByType.lua"]:31: in function `Refresh' [string "@Journalator_Display/Source/DataProviders/Display.lua"]:72: in function `callback' [string "@Journalator/Source/Archiving/LoadUpTo.lua"]:19: in function <...aceJournalator/Source/Archiving/LoadUpTo.lua:5> Locals: startTime = 1706836472 endTime = 1709428472 filter = defined @Journalator_Display/Source/DataProviders/SummaryByType.lua:31 result = { 1 =
{ } 2 =
{ } 3 =
{ } 4 =
{ } 5 =
{ } 6 =
{ } 7 =
{ } 8 =
{ } 9 =
{ } 10 =
{ } 11 =
{ } } Add = defined @Journalator_Display/Source/GetProfit.lua:6 incoming = 0 outgoing = 0 missions =
{ 1 =
{ } 2 =
{ } 3 =
{ } 4 =
{ } 5 =
{ } } (for generator) = defined =[C]:-1 (for state) =
{ 1 =
{ } 2 =
{ } 3 =
{ } 4 =
{ } 5 =
{ } } (for control) = 1 _ = 1 item =
{ source =
{ } tableType = 4 missionID = 2272 missionName = "Memory Error" money = 0 time = 1709428431 itemID = 177699 itemCount = 1 } filterItem =
{ itemName = "Memory Error" time = 1709428431 source =
{ } } (*temporary) = nil (*temporary) = Frame { 0 = CheckFiltersChanged = defined @Journalator_Display/Source/Display/FiltersContainer.lua:58 CharacterDropDown = Button { } GetFilters = defined @Journalator_Display/Source/Display/FiltersContainer.lua:156 GetSearch = defined @Journalator_Display/Source/Display/FiltersContainer.lua:127 filters =
{ } UpdateMinTime = defined @Journalator_Display/Source/Display/FiltersContainer.lua:167 OnShow = defined @Journalator_Display/Source/Display/FiltersContainer.lua:39 OnLoad = defined @Journalator_Display/Source/Display/FiltersContainer.lua:3 TimePeriodDropDown = Frame { } earliestRangeTime = 1706836464 GetTimeForRange = defined @Journalator_Display/Source/Display/FiltersContainer.lua:80 SearchFilter = EditBox { } pending = false FactionDropDown = Frame { } Filter = defined @Journalator_Display/Source/Display/FiltersContainer.lua:89 UpdateRealmsAndCharacters = defined @Journalator_Display/Source/Display/FiltersContainer.lua:48 ReceiveEvent = defined @Journalator_Display/Source/Display/FiltersContainer.lua:73 RealmDropDown = Button { } OnUpdate = defined @Journalator_Display/Source/Display/FiltersContainer.lua:43 } (*temporary) =
{ itemName = "Memory Error" time = 1709428431 source =
{ } } (*temporary) = true (*temporary) = "attempt to perform arithmetic on field 'moneyIn' (a nil value)" ```
plusmouse commented 6 months ago

image Find this in the latest alpha

tflo commented 6 months ago

Yes, it works for me too now. Though I think you should disable the left and right click scripts of the Mission Tables entry, as it brings up an empty frame (JNRView with only JNRViewBg, no listing).

Thank you!

tflo commented 6 months ago

Result since my last post:

Screenshot of Wow at Mar 5, 2024 at 13_04_45

(With 13 fully-developed mission tables.)

Well, nothing compared to the 150K+ per week in SL times, but still worth being tracked in Journalator, I think 😄

plusmouse commented 6 months ago

Yeah. Thanks for the feedback. I'll add a Mission Tables tab at some point with indicators as to which mission and table provided the gold (the data is stored, the UI is just missing).

tflo commented 6 months ago

which mission

Hmm, pretty irrelevant, I would say, since all the gold missions give roughly the same (23–25 gold). Before the reward nerf, it was different, IIRC.

which […] table

Slightly more interesting, but the outcome is predictable (Revendreth tables will be the worst, Night Fae and Maldraxxus the best).

So I would save those database (kilo)bytes for more interesting stuff 😉

plusmouse commented 6 months ago

Well its only 2 numbers, and who knows Blizzard might add good mission tables in the future :P

I won't prioritise adding the UI though, but it'll happen at some point.

tflo commented 6 months ago

Yeah, I would love to see mission tables again in future expansions (instead of increasing the gold income from quests/WQs, which seems to be their plan), because missions are something you can always do even in times when you don't have much time to play.