search

Auctionator / Journalator

World of Warcraft addon. Keep track of your gold making on the AH, crafting orders and with vendors
https://www.curseforge.com/wow/addons/journalator
MIT License
10 stars 6 forks source link

Higher frameStrata #81

Closed tflo closed 7 months ago

tflo commented 7 months ago

I think it would be convenient to have the Journalator window at a higher frameStrata, so that it is above the TSM/AH frame. The reason for this idea is that I often find myself browsing the journal while TSM is doing a lengthy AH scan:

As it is now jnr bad-fs8
frameStrata 'HIGH' jnr good-fs8

(The loading progress bar must be at 'DIALOG' then.)

The Journalator window is something you typically open when you actually want to see it (not something you keep open most of the time), so a relatively high strata would be justified, IMHO.

Thanks for considering.

plusmouse commented 7 months ago

As far as I'm concerned this is a TSM bug, as they shouldn't adopt such a high frame strata, which doesn't interact well with other Blizzard frames.

tflo commented 7 months ago

You are right, it's just TSM that is on HIGH (I thought it was also the normal AH frame, but that's just the higher layer if Journalator is already on screen).

Gonna try to fix it in my TSM then (which is already tweaked left and right 🤪).

tflo commented 5 months ago

After your reply, I followed your suggestion and fixed the strata of my TSM (high --> medium), which solved the problem without any glitches.

A few weeks ago it seems you added a conditional to Baganator, to set Baganator's strata to "HIGH" if TSM is loaded. So, now I have a similar problem with Journalator and Baganator as I had before with Journalator and TSM 🙃 (without my local TSM fix I would have the Baganator strata problem in addition to TSM.)

So maybe at the end wouldn't it be the better solution to set Journalator's strata to "HIGH"? (You could do it also with a TSM conditional, like with Baganator's strata.) It would then be better also for TSM users who don't modify their TSM copy.

And, as mentioned in the OP, I think for an addon like Journalator, which usually is only on screen for a short time (when the user looks something up), even an unconditional "HIGH" strata could be justified.

BTW, also removing the "clamp to screen" could help to make the handling of the Journalator frame less clunky, since the frame is quite large horizontally (more than half of my screen width).

plusmouse commented 5 months ago

Done the conditional now. Find it in the latest alpha once CF approves it.