Add new colors for WaveColor

Audacium / audacium

Free and open-source audio editor

https://audacium.github.io/audacium/

Other

703 stars 34 forks source link

Add new colors for WaveColor #25

Closed ClausMartini closed 3 years ago

ClausMartini commented 3 years ago

This Audacity fork needs a facelift in order to stand out (in my opinion). And what better way to do so than improving the current wave color system? Four colors is probably good enough for the basic to mid level user. For advanced users with large numbers of tracks, this isn't good enough. So this commit adds 20 colors to Wave Color selection. There are 2 file patches: AllThemeResources.h and TrackArtist.cpp.

[x] I made sure the code compiles on my machine.
[x] I made sure there are no unnecessary changes in the code.
[x] I made sure the title of the PR reflects the core meaning of the issue you are solving.
[x] I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?".
[x] I hereby reaffirm that I am licensing my contribution under the GNU General Public License v2.0 or later (GPL-2.0-or-later).

ClausMartini commented 3 years ago

@AnErrupTion A mistake. As you can see, this is work in progress. Should have said that in the description. Sorry. Just thought it'd make a fine addition to Audacium. So feel free to make all necessary changes as you see fit. @matt-hu Why would you request typos?

matt-vdv commented 3 years ago

@ClausMartini I'm not requesting them, you have made them, I'm pretty sure

ClausMartini commented 3 years ago

@matt-hu You're right. Sorry. My dyslexia. 😀

matt-vdv commented 3 years ago

@ClausMartini no worries! Tbh, I'm probably slightly dyslexic and had to look them up myself to see if that was the right spelling.

Oh and yes, you are very much right in that it needs a facelift

AnErrupTion commented 3 years ago

@ClausMartini Could you just answer the requested changes I put? There's a line you removed I'm curious about, that's all. And if you could remove reference to EXPERIMENTAL_DA it would be nice.

ClausMartini commented 3 years ago

@AnErrupTion Done!

AnErrupTion commented 3 years ago

My bad, you only need to keep the line #define LOGOWITHNAME_WIDTH 506. For the other line, I was only curious about it. You didn't have to add it again, I'm sure you had a reason you deleted it! If you could just fix that and explain me I'll merge :)

ClausMartini commented 3 years ago

Nah, it should be fine now. I'm sure I removed it by mistake in the first place.

AnErrupTion commented 3 years ago

Just the last thing, the very last before I can merge : You've removed #ifdef EXPERIMENTAL_DA, however you didn't remove the last 3 lines so it will cause errors. Could you simply only keep the line #define LOGOWITHNAME_WIDTH 506 and not the 2 other lines? Thanks if you do :)

AnErrupTion commented 3 years ago

Oh damn, forgot to say to remove the #endif too... this isn't your fault, don't worry! This is actually the last thing.

ClausMartini commented 3 years ago

Right. Sorry. I've been sitting on the computer all day, so forgive me if I seem completely spaced out. 😀 Thanks both of you @matt-hu and @AnErrupTion .

AnErrupTion commented 3 years ago

Thanks for your contribution!

ClausMartini commented 3 years ago

You're very welcome.