search

Auden-Musulin-Papers / amp-app

https://amp.acdh.oeaw.ac.at
MIT License
0 stars 2 forks source link

`[ ]` representing `<gap/>` should only be displayed if "Original text features" are enabled #185

Closed timofruehwirth closed 2 months ago

timofruehwirth commented 2 months ago

for example <gap quantity="1" unit="char" reason="illegible"/> in line 2958 in doc 0062

(NB: in most other cases, the gap is part of a deletion and therefore not displayed if "Original text features" are disabled)

linxOD commented 2 months ago

current logic: a gap@reason=illegible will not be hidden but is always visible while a gap@reason=deleted will be hidden

should this logic change? if yes, this will affect all other gap elements.

timofruehwirth commented 2 months ago

yes, you're right, let's stick with the current logic ...