search

Audentio / community-app-issues

2 stars 0 forks source link

Icons on Native verses Web #663

Open TFPleebo opened 3 years ago

TFPleebo commented 3 years ago

Describe the bug I wouldn’t call this a bug so to say, but this is a bit “messy.” In native to start a new thread you’ll press a button with a + sign. When you reply to a post however the icon is different.

Expected behavior I’m writing this here as I’m unsure of the options to alter the icons on the App. I suspect in the end product the new theme you’re using would match the setup for the App, but I wanted to make sure. You’d expect these two icons to be the same so the experience “flows” between web and native.

Screenshots 141D6EEE-FF41-4DC3-BECA-31CE19EA6B52

D1B39668-1620-4B1E-8823-B9690E62B2A4

Device details: Device: iPhone XR OS: iOS 14

Community App details Version: 0:14:4 Connected forum: Community App Staging

┆Issue is synchronized with this ClickUp by Unito

mikecreuzer commented 3 years ago

Agreed. They should both be green at least, but not same icon you mean correct? Assigning to Ian :D

Thanks for the report!

daltonp commented 3 years ago

Just to note, can replicate this on iOS as well

Ian-Hitt commented 3 years ago

Not sure what's best here. App uses a hard coded one-off green color that's only used for that button. I don't think that's a customization we'd want to make to the theme. The web view currently uses secondary brand color. Maybe the app should be updated to use that as well. We could update the web view to have that green as secondary brand color as well so that they are in sync with eachother

Ian-Hitt commented 3 years ago

In any case, I think this is a bug with the app, not the theme. The two need to be in sync, so the app needs to use a synced variable for this, whether its secondary brand color or something new

TFPleebo commented 3 years ago

Listening to how it’s coded it sounds like using the green in WebView by far would be easier to do. That said, I’d suspect it would conflict with several sites colors as well. I know I’d hear flack about it on TFP is we’d use that green. Using the secondary color however would likely be more work to code BUT offer a better end product.